-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Plugin E2E: Interact with Grafana http api on behalf of logged in user #965
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ukochka
approved these changes
Jun 20, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
🚀 PR was released in |
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
If a plugin has implemented RBAC, it may be necessary to run different tests suites for different user roles. Plugin-e2e offers a declarative way to create new users with a role in a setup project. In the following example, a new users with
Viewer
role is created in the setup project, and all tests in therun-tests-for-viewer
project starts already authenticated as that user.It's important to keep in mind that two different users (or credentials) are in play here. First, it's the credentials used to call the Grafana Http API to create the new user. These credentials requires elevated permissions. Secondly, it's the user being used to run the tests, which in this case has restricted permissions (viewer role).
Until now, the admin user used to interact with the Grafana http api has been using basic auth. This is not ideal since basic auth is disabled for scaffolded plugins. This PR changes that so that any interaction with the Grafana http api is done on behalf of a logged in user. Additionally, I've refactored the code so that all interactions with the Grafana api is encapsulated in a GrafanaAPIClient file. This helps separating the two concepts.
Which issue(s) this PR fixes:
Fixes ##968
Special notes for your reviewer:
📦 Published PR as canary version:
Canary Versions
✨ Test out this PR locally via: