Plugin E2E: Expose variable list page as fixture #942
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Name selector - Apply button selector
- Set dashboard in constructor - Allow specifying if the variable is first to ensure appropriate flow is used
aangelisc
requested review from
oshirohugo and
sunker
and removed request for
a team
aangelisc
added
minor
sunker
reviewed
Jun 4, 2024
There was a problem hiding this comment.
This is awesome, thanks for raising this PR @aangelisc!
Added some minor comments about the selectors and also had a question about server state. Otherwise looks great!
I know it's cumbersome to work with the selectors today, but FYI we're planning to change this so that they're no longer duplicated here and in grafana/e2e-selectors.
|
|
sunker
changed the title
plugin-e2e updates
sunker
approved these changes
Jun 11, 2024
There was a problem hiding this comment.
As discussed offline, I'm making some final adjustments to this PR since Andreas is OOO.
Thanks again for contributing @aangelisc!
|
🚀 PR was released in |
grafana-plugins-platform-bot
bot
added
the
released
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the
plugin-e2epackage with some more functionality related to template variables and dashboards.VariablePageto allow it to be reusedAlso have fixed a typo in the dashboard delete function that was attempting to delete a data source instead.
Required for grafana/azure-data-explorer-datasource#880
📦 Published PR as canary version:
Canary Versions✨ Test out this PR locally via: