Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update select option selector to use data-testid #912

Merged
merged 1 commit into from
May 28, 2024

Conversation

ashharrison90
Copy link
Contributor

@ashharrison90 ashharrison90 commented May 21, 2024

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

📦 Published PR as canary version: Canary Versions

✨ Test out this PR locally via:

npm install @grafana/[email protected]
# or 
yarn add @grafana/[email protected]

@ashharrison90 ashharrison90 added patch Increment the patch version when merged release Create a release when this pr is merged labels May 21, 2024
@ashharrison90 ashharrison90 self-assigned this May 21, 2024
@ashharrison90 ashharrison90 requested a review from a team as a code owner May 21, 2024 09:50
@ashharrison90 ashharrison90 requested review from jackw and removed request for a team May 21, 2024 09:50
Copy link

github-actions bot commented May 21, 2024

Hello! 👋 This repository uses Auto for releasing packages using PR labels.

✨ This PR can be merged and will trigger a new patch release.
NOTE: When merging a PR with the release label please avoid merging another PR. For further information see here.

@jackw jackw requested a review from sunker May 24, 2024 08:35
Copy link
Contributor

@sunker sunker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks for updating the selectors!

You can ignore the failing e2e tests for [email protected] - the selector resolver doesn't take build number into consideration, so it's assuming the selector value is data-testid Select option even though these changes are not merged to the main branch of Grafana yet. I plan to find better solutions for this in the near future.

@ashharrison90 ashharrison90 merged commit af423d6 into main May 28, 2024
18 of 19 checks passed
@ashharrison90 ashharrison90 deleted the ash/update-select-option-selector branch May 28, 2024 11:40
@grafana-plugins-platform-bot
Copy link

🚀 PR was released in @grafana/[email protected] 🚀

@grafana-plugins-platform-bot grafana-plugins-platform-bot bot added the released This issue/pull request has been released. label May 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
patch Increment the patch version when merged release Create a release when this pr is merged released This issue/pull request has been released.
Projects
Development

Successfully merging this pull request may close these issues.

2 participants