Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Plugin E2E: Remove custom selector engine #859

Merged
merged 2 commits into from
Apr 5, 2024
Merged

Conversation

sunker
Copy link
Contributor

@sunker sunker commented Apr 5, 2024

What this PR does / why we need it:

This PR removes the custom selector engine and also updates some tsdocs.

Instead of using the custom selector engine, it's recommended to use the getByGrafanaSelector method that is exposed in all Grafana pages.

// instead of this:
page.locator(`selector=data-testid code editor`);
// do this:
panelEditPage.getByGrafanaSelector('data-testid code editor')

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

📦 Published PR as canary version: Canary Versions

✨ Test out this PR locally via:

npm install @grafana/[email protected]
# or 
yarn add @grafana/[email protected]

@sunker sunker added major Increment the major version when merged release Create a release when this pr is merged labels Apr 5, 2024
Copy link

github-actions bot commented Apr 5, 2024

Hello! 👋 This repository uses Auto for releasing packages using PR labels.

✨ This PR can be merged and will trigger a new major release.
NOTE: When merging a PR with the release label please avoid merging another PR. For further information see here.

@sunker sunker changed the title Plugin e2e: Remove selector engine Plugin E2E: Remove selector engine Apr 5, 2024
@sunker sunker changed the title Plugin E2E: Remove selector engine Plugin E2E: Remove custom selector engine Apr 5, 2024
@sunker sunker marked this pull request as ready for review April 5, 2024 13:29
@sunker sunker requested a review from a team as a code owner April 5, 2024 13:29
@sunker sunker requested review from mckn and jackw and removed request for a team April 5, 2024 13:29
Copy link
Collaborator

@jackw jackw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🚀

@sunker sunker merged commit 16638c6 into main Apr 5, 2024
25 of 29 checks passed
@sunker sunker deleted the plugin-e2e/major-release branch April 5, 2024 13:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
major Increment the major version when merged release Create a release when this pr is merged
Projects
Development

Successfully merging this pull request may close these issues.

2 participants