Add service label for alerting integrations #5373
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ferril
had a problem deploying
to
github-pages
GitHub Actions
Failure
Ferril
had a problem deploying
to
github-pages
GitHub Actions
Failure
Ferril
had a problem deploying
to
github-pages
GitHub Actions
Failure
Konstantinov-Innokentii
had a problem deploying
to
github-pages
GitHub Actions
Failure
Konstantinov-Innokentii
had a problem deploying
to
github-pages
GitHub Actions
Failure
Konstantinov-Innokentii
had a problem deploying
to
github-pages
GitHub Actions
Failure
There was a problem hiding this comment.
Let's remove update_labels_cache task, it seems it's deprecated
|
|
||
| @shared_dedicated_queue_retry_task(autoretry_for=(Exception,), retry_backoff=True, max_retries=MAX_RETRIES) | ||
| def add_service_label_for_alerting_integrations(): | ||
| """Starts tasks that add `service_name` dynamic label to custom labels for alerting integrations""" |
There was a problem hiding this comment.
Please, add comment that it's intended for 1-time run. Also, let's stop use term custom labels
TODO: 1. Save custom labels cache 2. Check if to_internal & to_representation are called automatically for IntegrationAlertGroupLabelsSerializer 3. Task for create default label
Konstantinov-Innokentii
had a problem deploying
to
github-pages
GitHub Actions
Failure
Konstantinov-Innokentii
had a problem deploying
to
github-pages
GitHub Actions
Failure
Konstantinov-Innokentii
had a problem deploying
to
github-pages
GitHub Actions
Failure
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does
Adds
service_namedynamic labels for Grafana Alerting integrations by defaultWhich issue(s) this PR closes
Related to https://github.com/grafana/oncall-private/issues/2975
Checklist
pr:no public docsPR label added if not required)release:). These labels dictate how your PR willshow up in the autogenerated release notes.