chore: remove references to SlackMessage._channel_id
#5325
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tGroup.prevent_posting_alerts`
joeyorlando
added
pr:no public docs
joeyorlando
had a problem deploying
to
github-pages
GitHub Actions
Failure
joeyorlando
had a problem deploying
to
github-pages
GitHub Actions
Failure
joeyorlando
had a problem deploying
to
github-pages
GitHub Actions
Failure
joeyorlando
commented
Dec 4, 2024
There was a problem hiding this comment.
I don't believe this is needed anymore? (was removing engine/engine/management/commands/batch_migrate_slack_message_channel.py and decided to remove this as well)
joeyorlando
had a problem deploying
to
github-pages
GitHub Actions
Error
joeyorlando
had a problem deploying
to
github-pages
GitHub Actions
Error
joeyorlando
had a problem deploying
to
github-pages
GitHub Actions
Error
joeyorlando
had a problem deploying
to
github-pages
GitHub Actions
Failure
joeyorlando
had a problem deploying
to
github-pages
GitHub Actions
Failure
joeyorlando
had a problem deploying
to
github-pages
GitHub Actions
Failure
joeyorlando
changed the title
SlackMessage._channel_id + remove AlertGroup.prevent_posting_alertsSlackMessage._channel_id
joeyorlando
temporarily deployed
to
github-pages
GitHub Actions
Inactive
joeyorlando
temporarily deployed
to
github-pages
GitHub Actions
Inactive
joeyorlando
temporarily deployed
to
github-pages
GitHub Actions
Inactive
joeyorlando
commented
Dec 4, 2024
| @@ -417,6 +417,10 @@ def status(self) -> int: | |||
| ) | |||
|
|
|||
| prevent_posting_alerts = models.BooleanField(default=False) | |||
| """ | |||
| TODO: this column is no longer used, drop it in a subsequent PR/release | |||
There was a problem hiding this comment.
hesitant to do this operation in this PR, clean-up for another day 🙂
joeyorlando
commented
Dec 4, 2024
Comment on lines
+16
to
+22
| operations = [ | ||
| common.migrations.remove_field.RemoveFieldDB( | ||
| model_name="SlackMessage", | ||
| name="active_update_task_id", | ||
| remove_state_migration=("slack", "0008_remove_slackmessage_active_update_task_id_state"), | ||
| ), | ||
| ] |
There was a problem hiding this comment.
this is instant (on a prod clone):
mysql> ALTER TABLE slack_slackmessage DROP COLUMN active_update_task_id;
Query OK, 0 rows affected (0.80 sec)
Records: 0 Duplicates: 0 Warnings: 0
3 tasks
joeyorlando
added a commit
that referenced
this pull request
Dec 6, 2024
…on` fields (#5340) # What this PR does Follow-up cleanup PR for #5325 (and #5330) ## Checklist - [x] Unit, integration, and e2e (if applicable) tests updated - [x] Documentation added (or `pr:no public docs` PR label added if not required) - [x] Added the relevant release notes label (see labels prefixed w/ `release:`). These labels dictate how your PR will show up in the autogenerated release notes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does
SlackMessage.channel_id(CHARfield) toSlackMessage.channel(foreign key relationship) #5292, and now thatSlackMessage.channelhas been migrated viaengine/apps/slack/migrations/0007_migrate_slackmessage_channel_id.py, this PR removes reads/writes fromSlackMessage._channel_idtoSlackMessage.channel. In a separate PR I will focus on dropping that column from the model/db.SlackMessage.active_update_task_id. There're zero references to this column in the codebase.manage.pycommands that're no longer needed:engine/engine/management/commands/alertmanager_v2_migrate.py(and it's associated tests)engine/engine/management/commands/batch_migrate_slack_message_channel.pyChecklist
pr:no public docsPR label added if not required)release:). These labels dictate how your PR willshow up in the autogenerated release notes.