Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: patch data migration scripts for non-MySQL databases #5297

Merged
merged 1 commit into from
Nov 26, 2024
Merged

fix: patch data migration scripts for non-MySQL databases #5297

merged 1 commit into from
Nov 26, 2024

Conversation

joeyorlando
Copy link
Contributor

@joeyorlando joeyorlando commented Nov 26, 2024 •
edited
Loading

What this PR does

Which issue(s) this PR closes

Fixes #5244 (comment)

Checklist

  • Unit, integration, and e2e (if applicable) tests updated
  • Documentation added (or pr:no public docs PR label added if not required)
  • Added the relevant release notes label (see labels prefixed w/ release:). These labels dictate how your PR will
    show up in the autogenerated release notes.

@joeyorlando joeyorlando added pr:no public docs Added to a PR that does not require public documentation updates release:patch PR will be added to "Other Changes" section of release notes labels Nov 26, 2024
@joeyorlando joeyorlando requested a review from a team as a code owner November 26, 2024 10:52
joeyorlando
joeyorlando commented Nov 26, 2024
View reviewed changes
Copy link
Contributor Author

@joeyorlando joeyorlando left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

all of the "new" migration related code added under the else clauses (ie. code to run on non-MySQL databases), was re-used from #5233.

@joeyorlando joeyorlando mentioned this pull request Nov 26, 2024
Closed
@joeyorlando joeyorlando merged commit 98f6b1b into dev Nov 26, 2024
30 checks passed
@joeyorlando joeyorlando deleted the jorlando/fix-data-migration-scripts-on-non-mysql-dbs branch November 26, 2024 19:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
pr:no public docs Added to a PR that does not require public documentation updates release:patch PR will be added to "Other Changes" section of release notes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Migrations failing when upgrading to 1.12.1
1 participant
@joeyorlando