Upgrade to latest mimir-prometheus with Prometheus 3.0 changes #9844
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aknuds1
force-pushed
the
arve/upgrade-mimir-prometheus
branch
22 times, most recently
from
cb6d823 to
a1b4f48
Compare
aknuds1
changed the title
aknuds1
force-pushed
the
arve/upgrade-mimir-prometheus
branch
from
a1b4f48 to
6a3bfe1
Compare
|
To address one small set of test failures: #9854 |
aknuds1
force-pushed
the
arve/upgrade-mimir-prometheus
branch
5 times, most recently
from
71feed6 to
69c0bd2
Compare
aknuds1
force-pushed
the
arve/upgrade-mimir-prometheus
branch
from
1d21d67 to
a5035ca
Compare
Signed-off-by: Arve Knudsen <[email protected]>
aknuds1
force-pushed
the
arve/upgrade-mimir-prometheus
branch
from
a5035ca to
687c249
Compare
Signed-off-by: Arve Knudsen <[email protected]>
Signed-off-by: Arve Knudsen <[email protected]>
Signed-off-by: Arve Knudsen <[email protected]>
Signed-off-by: Arve Knudsen <[email protected]>
Signed-off-by: Arve Knudsen <[email protected]>
aknuds1
force-pushed
the
arve/upgrade-mimir-prometheus
branch
from
dd6d215 to
22e1ab7
Compare
Signed-off-by: Arve Knudsen <[email protected]>
colega
reviewed
Nov 27, 2024
colega
reviewed
Nov 27, 2024
colega
reviewed
Nov 27, 2024
colega
reviewed
Nov 27, 2024
| // ExtendPromQL enriches PromQL with Mimir extensions. | ||
| func ExtendPromQL() { | ||
| // Keep an alias for users using holt_winters, even though dropped in Prometheus v3. | ||
| promql.FunctionCalls["holt_winters"] = promql.FunctionCalls["double_exponential_smoothing"] |
There was a problem hiding this comment.
Should we start a deprecation path for this function?
There was a problem hiding this comment.
I don't know, I don't think we discussed it. Could you remind me of how to do so?
There was a problem hiding this comment.
Discussed offline that we'll discuss eventual deprecation after this PR.
There was a problem hiding this comment.
We have a list of deprecated features in about-versioning.md. Anyway, not blocking this PR on that.
Signed-off-by: Arve Knudsen <[email protected]>
Signed-off-by: Arve Knudsen <[email protected]>
Signed-off-by: Arve Knudsen <[email protected]>
Co-authored-by: Oleg Zaytsev <[email protected]>
Co-authored-by: Oleg Zaytsev <[email protected]>
Signed-off-by: Arve Knudsen <[email protected]>
Signed-off-by: Arve Knudsen <[email protected]>
Signed-off-by: Arve Knudsen <[email protected]>
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does
Upgrade to mimir-prometheus@fd7e39a8798e, which syncs in Prometheus 3.0 changes.
NB: I add a
go-kit/logtoslogadapter, since Prometheus now uses the latter.TODO:
Which issue(s) this PR fixes or relates to
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX].about-versioning.mdupdated with experimental features.