Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

mimir-build-image: bump Go to 1.23.2 #9491

Merged
merged 4 commits into from
Oct 2, 2024
Merged

mimir-build-image: bump Go to 1.23.2 #9491

merged 4 commits into from
Oct 2, 2024

Conversation

narqo
Copy link
Contributor

@narqo narqo commented Oct 2, 2024

What this PR does

Here we update Go version to 1.23.2 (release notes)

Which issue(s) this PR fixes or relates to

Needs backporting to release-2.14

Checklist

  • Tests updated.
  • Documentation added.
  • CHANGELOG.md updated - the order of entries should be [CHANGE], [FEATURE], [ENHANCEMENT], [BUGFIX].
  • about-versioning.md updated with experimental features.

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Oct 2, 2024

Building new version of mimir-build-image. After image is built and pushed to Docker Hub, a new commit will automatically be added to this PR with new image version grafana/mimir-build-image:pr9491-be37c556e2. This can take up to 1 hour.

@narqo narqo marked this pull request as ready for review October 2, 2024 09:20
@narqo narqo requested a review from a team as a code owner October 2, 2024 09:20
pstibrany
pstibrany approved these changes Oct 2, 2024
View reviewed changes
Copy link
Member

@pstibrany pstibrany left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. (nit: Can we avoid formatting changes in Dockerfile to minimize diff?)

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Oct 2, 2024

Building new version of mimir-build-image. After image is built and pushed to Docker Hub, a new commit will automatically be added to this PR with new image version grafana/mimir-build-image:pr9491-80f5778956. This can take up to 1 hour.

@narqo
Copy link
Contributor Author

narqo commented Oct 2, 2024

Can we avoid formatting changes in Dockerfile to minimize diff

Oops. Zed editor seems to have some opinion about this Dockerfile. I've reverted unrelated changes now.

@narqo narqo force-pushed the vldmr/mimir-build-image-go-123 branch from 263efb7 to 81ce25d Compare October 2, 2024 10:27
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Oct 2, 2024

Building new version of mimir-build-image. After image is built and pushed to Docker Hub, a new commit will automatically be added to this PR with new image version grafana/mimir-build-image:pr9491-80f5778956. This can take up to 1 hour.

1 similar comment
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Oct 2, 2024

Building new version of mimir-build-image. After image is built and pushed to Docker Hub, a new commit will automatically be added to this PR with new image version grafana/mimir-build-image:pr9491-80f5778956. This can take up to 1 hour.

@narqo narqo enabled auto-merge (squash) October 2, 2024 11:32
@aknuds1
Copy link
Contributor

aknuds1 commented Oct 2, 2024

@narqo you have to push an amended commit or something, to re-trigger CI.

@narqo narqo force-pushed the vldmr/mimir-build-image-go-123 branch from 79a8c2f to d5bde4f Compare October 2, 2024 13:01
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Oct 2, 2024

Not building new version of mimir-build-image. This PR modifies mimir-build-image/Dockerfile, but the image grafana/mimir-build-image:pr9491-80f5778956 already exists.

@narqo narqo merged commit 30cdde9 into main Oct 2, 2024
30 checks passed
@narqo narqo deleted the vldmr/mimir-build-image-go-123 branch October 2, 2024 13:18
grafanabot pushed a commit that referenced this pull request Oct 2, 2024
@narqo @grafanabot
mimir-build-image: bump Go to 1.23.2 (#9491)
7e692e7 
* mimir-build-image: bump Go to 1.23 latest

Signed-off-by: Vladimir Varankin <[email protected]>

* Update build image version to pr9491-be37c556e2

* fixup! mimir-build-image: bump Go to 1.23 latest

* Update build image version to pr9491-80f5778956

---------

Signed-off-by: Vladimir Varankin <[email protected]>
Co-authored-by: narqo <[email protected]>
(cherry picked from commit 30cdde9)
@grafanabot grafanabot mentioned this pull request Oct 2, 2024
Merged
narqo added a commit that referenced this pull request Oct 2, 2024
@grafanabot @narqo
mimir-build-image: bump Go to 1.23.2 (#9491) (#9499)
3b094fa 
* mimir-build-image: bump Go to 1.23 latest

Signed-off-by: Vladimir Varankin <[email protected]>

* Update build image version to pr9491-be37c556e2

* fixup! mimir-build-image: bump Go to 1.23 latest

* Update build image version to pr9491-80f5778956

---------

Signed-off-by: Vladimir Varankin <[email protected]>
Co-authored-by: narqo <[email protected]>
(cherry picked from commit 30cdde9)

Co-authored-by: Vladimir Varankin <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pstibrany pstibrany pstibrany approved these changes

@aknuds1 aknuds1 aknuds1 approved these changes

@wilfriedroset wilfriedroset Awaiting requested review from wilfriedroset wilfriedroset is a code owner

@vaxvms vaxvms Awaiting requested review from vaxvms vaxvms is a code owner

@bubu11e bubu11e Awaiting requested review from bubu11e bubu11e is a code owner

Assignees
No one assigned
Labels
backport release-2.14
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@narqo @aknuds1 @pstibrany