Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Documentation: add Azure workload identity example #8332

Open
wants to merge 14 commits into
base: main
Choose a base branch
from

Conversation

GVengelen
Copy link

What this PR does

I've added an configuration example for using workload identity on Azure object storage for Mimir.

Which issue(s) this PR fixes or relates to

No issue

Checklist

  • [N/A] Tests updated.
  • Documentation added.
  • [x ] CHANGELOG.md updated - the order of entries should be [CHANGE], [FEATURE], [ENHANCEMENT], [BUGFIX].
  • about-versioning.md updated with experimental features.

@GVengelen GVengelen requested review from jdbaldry and a team as code owners June 11, 2024 06:44
@CLAassistant
Copy link

CLAassistant commented Jun 11, 2024

CLA assistant check
All committers have signed the CLA.

@GVengelen GVengelen changed the title Patch 1 Documentation: add Azure workload identity example Jun 11, 2024
@dimitarvdimitrov dimitarvdimitrov added the type/docs Improvements or additions to documentation label Jun 20, 2024
Copy link
Contributor

@dimitarvdimitrov dimitarvdimitrov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is great! Thank you for the contribution! I'll leave someone from the docs team to vet this for style and structure, but the content makes sense (even though I'm not an azure expert)

@dimitarvdimitrov
Copy link
Contributor

The CHANGELOG has just been cut to prepare for the next Mimir release. Please rebase main and eventually move the CHANGELOG entry added / updated in this PR to the top of the CHANGELOG document. Thanks!

@GVengelen
Copy link
Author

GVengelen commented Jun 24, 2024

The CHANGELOG has just been cut to prepare for the next Mimir release. Please rebase main and eventually move the CHANGELOG entry added / updated in this PR to the top of the CHANGELOG document. Thanks!

@tacole02 Can you have a second look, I think I've processed all the comments

@tacole02
Copy link
Contributor

Looks great. Thank you!

Copy link
Contributor

@dimitarvdimitrov dimitarvdimitrov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

a few nitpicks on the changelog

CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
Copy link
Contributor

github-actions bot commented Jan 7, 2025

Thank you for your contribution. This pull request has been marked as stale because it has had no activity in the last 150 days. It will be closed in 30 days if there is no further activity. If you need more time, you can add a comment to the PR.

@github-actions github-actions bot added the stale label Jan 7, 2025
@dimitarvdimitrov dimitarvdimitrov enabled auto-merge (squash) January 7, 2025 08:47
@github-actions github-actions bot removed the stale label Jan 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release/notified-changelog-cut type/docs Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants