Upgrade mimir-prometheus #10467
Closed
Upgrade mimir-prometheus #10467
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
charleskorn
requested review from
stevesg,
grafanabot and
a team
as code owners
pracucci
reviewed
Jan 17, 2025
| @@ -241,7 +250,7 @@ func (c *PostingsForMatchersCache) postingsForMatchersPromise(ctx context.Contex | |||
|
|
|||
| sizeBytes := int64(len(key) + size.Of(promise)) | |||
|
|
|||
| c.onPromiseExecutionDone(ctx, key, c.timeNow(), sizeBytes, promise.err) | |||
| c.onPromiseExecutionDone(ctx, key, ts, sizeBytes, promise.err) | |||
There was a problem hiding this comment.
This subtle change could be quite impactful. It was done on purpose reading c.timeNow() at this point, to make the cache TTL lasting longer. The problem is that if you're running a very complex index lookup that takes few seconds, by the time you reach this point, the TTL of 10s may be either already expired or close to expire, effectively invalidating the benefits of the cache.
There was a problem hiding this comment.
Good catch, I'll revert this and find another way to do this.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does
This PR upgrades mimir-prometheus to include grafana/mimir-prometheus#820.
I haven't added a changelog entry given this is a minor tracing improvement.
Which issue(s) this PR fixes or relates to
(none)
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX].about-versioning.mdupdated with experimental features.