Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make use of LabelHints.Limit for LabelNames and LabelValues requests (#8805) #10410

Open
wants to merge 39 commits into
base: main
Choose a base branch
from
Open

Make use of LabelHints.Limit for LabelNames and LabelValues requests (#8805) #10410

wants to merge 39 commits into from
+569 −223

Conversation

santileira
Copy link
Contributor

@santileira santileira commented Jan 12, 2025 •
edited
Loading

What this PR does

Make use of LabelHints.Limit for LabelNames and LabelValues on the StoreGatewayClient, Distributor and Ingester.

Which issue(s) this PR fixes or relates to

Fixes #8805

Checklist

  • Tests updated.
  • Documentation added.
  • CHANGELOG.md updated - the order of entries should be [CHANGE], [FEATURE], [ENHANCEMENT], [BUGFIX].
  • about-versioning.md updated with experimental features.

@santileira santileira changed the title Use LabelHints.Limit Make use of LabelHints.Limit for label names and values requests Jan 18, 2025
@santileira santileira changed the title Make use of LabelHints.Limit for label names and values requests Make use of LabelHints.Limit for LabelNames and LabelValues requests Jan 19, 2025
@santileira santileira marked this pull request as ready for review January 19, 2025 20:09
@santileira santileira requested a review from a team as a code owner January 19, 2025 20:09
@santileira santileira mentioned this pull request Jan 19, 2025
Open
@santileira santileira changed the title Make use of LabelHints.Limit for LabelNames and LabelValues requests Make use of LabelHints.Limit for LabelNames and LabelValues requests (#8805) Jan 19, 2025
aknuds1
aknuds1 reviewed Jan 21, 2025
View reviewed changes
Copy link
Contributor

@aknuds1 aknuds1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To me it looks pretty good, but I suggest some improvements.

pkg/distributor/distributor.go Outdated Show resolved Hide resolved
pkg/distributor/distributor_test.go Outdated Show resolved Hide resolved
pkg/distributor/distributor_test.go Outdated Show resolved Hide resolved
pkg/distributor/distributor_test.go Outdated Show resolved Hide resolved
pkg/distributor/distributor_test.go Show resolved Hide resolved
pkg/querier/distributor_queryable_test.go Outdated Show resolved Hide resolved
pkg/querier/tenantfederation/merge_queryable_test.go Outdated Show resolved Hide resolved
pkg/querier/tenantfederation/merge_queryable_test.go Outdated Show resolved Hide resolved
pkg/storegateway/bucket.go Outdated Show resolved Hide resolved
pkg/storegateway/bucket.go Outdated Show resolved Hide resolved
santileira and others added 13 commits January 21, 2025 10:06
@santileira @aknuds1
Update pkg/distributor/distributor_test.go
61dcc6d 
Co-authored-by: Arve Knudsen <[email protected]>
@santileira @aknuds1
Update pkg/querier/tenantfederation/merge_queryable_test.go
7d0dad4 
Co-authored-by: Arve Knudsen <[email protected]>
@santileira @aknuds1
Update pkg/storegateway/bucket.go
fb27243 
Co-authored-by: Arve Knudsen <[email protected]>
@santileira @aknuds1
Update pkg/storegateway/bucket.go
b4df2b8 
Co-authored-by: Arve Knudsen <[email protected]>
@santileira @aknuds1
Update CHANGELOG.md
54d5cd2 
Co-authored-by: Arve Knudsen <[email protected]>
@santileira @aknuds1
Update pkg/distributor/distributor.go
4db9a13 
Co-authored-by: Arve Knudsen <[email protected]>
@santileira @aknuds1
Update pkg/distributor/distributor_test.go
b9f0fd8 
Co-authored-by: Arve Knudsen <[email protected]>
@santileira @aknuds1
Update pkg/distributor/distributor_test.go
80a21bf 
Co-authored-by: Arve Knudsen <[email protected]>
@santileira @aknuds1
Update pkg/distributor/distributor_test.go
753017b 
Co-authored-by: Arve Knudsen <[email protected]>
@santileira @aknuds1
Update pkg/ingester/client/compat.go
d436ed8 
Co-authored-by: Arve Knudsen <[email protected]>
@santileira @aknuds1
Update pkg/ingester/client/compat.go
30bb594 
Co-authored-by: Arve Knudsen <[email protected]>
@santileira @aknuds1
Apply suggestions from code review
3a762ff 
Co-authored-by: Arve Knudsen <[email protected]>
@santileira @aknuds1
Apply suggestions from code review
c246dc6 
Co-authored-by: Arve Knudsen <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aknuds1 aknuds1 Awaiting requested review from aknuds1

@charleskorn charleskorn Awaiting requested review from charleskorn

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
component/distributor component/ingester component/querier component/store-gateway
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Make use of LabelHints.Limit for label names and values requests
2 participants
@santileira @aknuds1