ingester: Hide tokens in ingester ring status page when ingest storage is enabled #10399
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexweav
force-pushed
the
alexweav/hide-tokens-ingest-storage
branch
from
fa61d9a to
64753c2
Compare
narqo
approved these changes
Jan 15, 2025
tacole02
approved these changes
Jan 15, 2025
alexweav
force-pushed
the
alexweav/hide-tokens-ingest-storage
branch
from
64753c2 to
192000f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does
When ingest storage is enabled, the ingester ring is used for service discovery but the partition ring is now used to match series to ingesters. This means the ingester ring's tokens are not used anymore. This PR hides token-related fields from the ingester ring status page when in ingest storage mode.
Leverages this dskit option (which has example screenshots): grafana/dskit#633
Which issue(s) this PR fixes or relates to
Contrib https://github.com/grafana/mimir-squad/issues/2350
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX].about-versioning.mdupdated with experimental features.