Bux fix for issue #8914 - Alertmanager error using custom function queryFromGeneratorURL #10358
+2
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
function queryFromGeneratorURL parses the generator URL with url.Parse() then calls url.QueryUnescape() However url.Parse() already calls url.QueryUnescape(): https://github.com/golang/go/blob/7a2e88e9117e838f258b175fa535f671396d13da/src/net/url/url.go#L970 Query parameters containing characters `%` and `+` will be decoded incorrectly.
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Function queryFromGeneratorURL parses the generator URL with url.Parse() then calls url.QueryUnescape()
However url.Parse() already calls url.QueryUnescape():
https://github.com/golang/go/blob/7a2e88e9117e838f258b175fa535f671396d13da/src/net/url/url.go#L970
Query parameters containing characters
%and+will be decoded incorrectly because of the double call to the unescape function.What this PR does
Which issue(s) this PR fixes or relates to
Fixes #8914
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX].about-versioning.mdupdated with experimental features.