-
Notifications
You must be signed in to change notification settings - Fork 544
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
mimir-distributed: allow components to override their container image #10340
base: main
Are you sure you want to change the base?
Conversation
Signed-off-by: Vladimir Varankin <[email protected]>
Signed-off-by: Vladimir Varankin <[email protected]>
Signed-off-by: Vladimir Varankin <[email protected]>
Signed-off-by: Vladimir Varankin <[email protected]>
a650f8a
to
d559783
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can you also include the keys in the values.yaml? Since we still want to use the top-level image
, then you can make the new <component>.image
be a comment. Something like the TSC examples
mimir/operations/helm/charts/mimir-distributed/values.yaml
Lines 873 to 883 in fc8af05
# -- topologySpreadConstraints allows to customize the default topologySpreadConstraints. This can be either a single dict as shown below or a slice of topologySpreadConstraints. | |
# labelSelector is taken from the constraint itself (if it exists) or is generated by the chart using the same selectors as for services. | |
topologySpreadConstraints: | |
maxSkew: 1 | |
topologyKey: kubernetes.io/hostname | |
whenUnsatisfiable: ScheduleAnyway | |
# minDomains: 1 | |
# nodeAffinityPolicy: Honor | |
# nodeTaintsPolicy: Honor | |
# matchLabelKeys: | |
# - pod-template-hash |
that's basically the only documentation we have of helm chart features (plus the changelog, which is barely documentation)
@@ -30,6 +30,7 @@ Entries should include a reference to the Pull Request that introduced the chang | |||
## main / unreleased | |||
|
|||
* [CHANGE] Memcached: Update to Memcached 1.6.34. #10318 | |||
* [ENHANCEMENT] Add support for individual components to override their container image. #10340 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i've been trying to make the changelog enough for anyone to get the gist of a change and know how to use it. Can you give an example of overriding the image for a component? Something like ingester.image.tag
and ingester.image.repository
. Or explain that there's an image
object under all component objects now
Build mimir image reference based on whether enterprise features are requested. The component local values always take precedence. | ||
Params: | ||
ctx = . context | ||
component = component name (optional) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
componentSectionFromName
errors out if the component doesn't exist, so i think component
isn't optional
What this PR does
The PR updates the Helm chart to allow an individual component to override its container image reference via the component's local values. E.g.
The order in which the values take precedence is:
Which issue(s) this PR fixes or relates to
Fixes #10237
Checklist
CHANGELOG.md
updated - the order of entries should be[CHANGE]
,[FEATURE]
,[ENHANCEMENT]
,[BUGFIX]
.about-versioning.md
updated with experimental features.