Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MQE: Add support for irate and idelta function #10326

Merged
merged 11 commits into from
Jan 3, 2025
Merged

MQE: Add support for irate and idelta function #10326

merged 11 commits into from
Jan 3, 2025

Conversation

lamida
Copy link
Contributor

@lamida lamida commented Jan 1, 2025 •
edited
Loading

What this PR does

Which issue(s) this PR fixes or relates to

Fixes #

Checklist

  • Tests updated.
  • Documentation added.
  • CHANGELOG.md updated - the order of entries should be [CHANGE], [FEATURE], [ENHANCEMENT], [BUGFIX].
  • about-versioning.md updated with experimental features.

@lamida
Implement irate and idelta
b094639 
Signed-off-by: Jon Kartago Lamida <[email protected]>
@lamida lamida requested a review from a team as a code owner January 1, 2025 16:03
@lamida lamida marked this pull request as draft January 1, 2025 16:03
lamida added 4 commits January 2, 2025 18:18
@lamida
Fix irate and idelta implementation and move it inside range_vectors.go
f6cc9cc 
Signed-off-by: Jon Kartago Lamida <[email protected]>
@lamida
Remove unneeded arguments
9fe6d21 
Signed-off-by: Jon Kartago Lamida <[email protected]>
@lamida
Fix lint
e4c9f7d 
Signed-off-by: Jon Kartago Lamida <[email protected]>
@lamida
Fix promql test whitespace
a5e8dd7 
Signed-off-by: Jon Kartago Lamida <[email protected]>
@lamida lamida marked this pull request as ready for review January 3, 2025 01:47
jhesketh
jhesketh reviewed Jan 3, 2025
View reviewed changes
Copy link
Contributor

@jhesketh jhesketh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggestion for some tests:

  • Something with a reset counter
  • Previous sample is a Histogram, so it needs to look back further (if that's consistent with promql)

pkg/streamingpromql/operators/functions/range_vectors.go Outdated Show resolved Hide resolved
pkg/streamingpromql/operators/functions/range_vectors.go Outdated Show resolved Hide resolved
pkg/streamingpromql/operators/functions/range_vectors.go Outdated Show resolved Hide resolved
pkg/streamingpromql/operators/functions/range_vectors.go Show resolved Hide resolved
lamida and others added 5 commits January 3, 2025 10:50
@lamida
Copy link
Contributor Author

lamida commented Jan 3, 2025

Suggestion for some tests:

  • Something with a reset counter
  • Previous sample is a Histogram, so it needs to look back further (if that's consistent with promql)

More tests are added in edaf824

@lamida
Move len var further up
1b1f359 
Signed-off-by: Jon Kartago Lamida <[email protected]>
jhesketh
jhesketh approved these changes Jan 3, 2025
View reviewed changes
Copy link
Contributor

@jhesketh jhesketh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for that.

We could add a test (outside of the testdata tests) to check the head/tail boundaries of the ring buffer, but I'm happy as it is.

@lamida lamida merged commit c281692 into main Jan 3, 2025
29 checks passed
@lamida lamida deleted the lamida/mqe-irate branch January 3, 2025 07:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jhesketh jhesketh jhesketh approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lamida @jhesketh