update Mimir / Reads and Remote Ruler Reads dashboard with query scheduler metrics #10290
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
francoposa
changed the title
tacole02
approved these changes
Dec 27, 2024
narqo
reviewed
Jan 2, 2025
| $.queryPanel( | ||
| [ | ||
| 'sum by(query_component) (cortex_query_scheduler_querier_inflight_requests{quantile="0.99", %s})' % [$.jobMatcher(querySchedulerJobName)], | ||
| 'cortex_query_scheduler_connected_querier_clients', |
There was a problem hiding this comment.
I think there's a typo here:
cortex_query_scheduler_connected_querier_clientsneeds a label selector (ie. via thejobMatcher)- we should probably aggregate it with sum to compare it with p99's metrics
dimitarvdimitrov
approved these changes
Jan 2, 2025
francoposa
force-pushed
the
francoposa/dashboard-scheduler-querier-inflight-requests
branch
from
cd09db9 to
6dd7d24
Compare
francoposa
deleted the
francoposa/dashboard-scheduler-querier-inflight-requests
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does
Introduces a dashboard panel row showing the
cortex_query_scheduler_querier_inflight_requestsby query component against the totalcortex_query_scheduler_connected_querier_clientsmetric.The
cortex_query_scheduler_querier_inflight_requestsis a Summary metric designed to capture the peak utilization of the query-scheduler <-> querier connections with inflight query processing in order to help identify saturation of the ingesters or store-gateways. The summary metric's lower percentiles are not particularly useful.It also updates some of the tooltip descriptions about the query scheduler rows to be more accurate to the new design.
Which issue(s) this PR fixes or relates to
Fixes #
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX].about-versioning.mdupdated with experimental features.