jsonnet: fix rollout-operator ports #10273
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix set ports in deployment, service and webhooks for rollout-operator
56quarters
requested changes
Dec 18, 2024
There was a problem hiding this comment.
The issue #10272 didn't mention why you want the service and containers to use the same port for HTTPS. The current configuration works today and so we don't want to change this.
Using the same service and container port is not essential. The main problem is that only port 8001 was declared in the container, and only port 8443/443 was declared in the service. It turns out that the call from webhooks is unreachable. Changing the ports is just a reduction to a unified approach to creating services (returned to the original one). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does
Implements correct port specification for rollout-operator in deployment, service, MutatingWebhookConfiguration and ValidatingWebhookConfiguration
Which issue(s) this PR fixes or relates to
Fixes #10272
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX].