OTLP: add CLI flag for 'quiet zero' #10238
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tacole02
reviewed
Dec 13, 2024
| @@ -956,6 +956,11 @@ instance_limits: | |||
| # limiting feature.) | |||
| # CLI flag: -distributor.reusable-ingester-push-workers | |||
| [reusable_ingester_push_workers: <int> | default = 2000] | |||
|
|
|||
| # (advanced) Change the implementation of Otel startTime from a real zero to a | |||
There was a problem hiding this comment.
Suggested change
| # (advanced) Change the implementation of Otel startTime from a real zero to a | |
| # (advanced) Change the implementation of OTel startTime from a real zero to a |
There was a problem hiding this comment.
Thanks. This flag is not supposed to appear in the docs; I will need to research how to achieve that.
There was a problem hiding this comment.
Hey @bboreham I just learned how to do so, simply append doc:"hidden" to it:
EnableStartTimeQuietZero bool `yaml:"start_time_quiet_zero" category:"advanced" doc:"hidden"`
tacole02
approved these changes
Dec 13, 2024
jesusvazquez
force-pushed
the
quiet-zeros-flag
branch
from
8de646b to
3d06383
Compare
jesusvazquez
force-pushed
the
quiet-zeros-flag
branch
from
8b14ffd to
2f556e2
Compare
jesusvazquez
approved these changes
Jan 2, 2025
krajorama
approved these changes
Jan 3, 2025
So that we can update all ingesters before enabling this in distributors.
Signed-off-by: Jesus Vazquez <[email protected]>
jesusvazquez
force-pushed
the
quiet-zeros-flag
branch
from
70adf14 to
b06b956
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So that we can update all ingesters before enabling this in distributors.
To be used together with grafana/mimir-prometheus#791
What this PR does
Which issue(s) this PR fixes or relates to
Fixes #
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX].about-versioning.mdupdated with experimental features.