-
Notifications
You must be signed in to change notification settings - Fork 544
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Unify mimirtool authentication options and add extra-headers support for commands that depend on MimirClient #10179
Conversation
38ddbaa
to
832acff
Compare
The CHANGELOG has just been cut to prepare for the next release. Please rebase |
0892e5d
to
931b093
Compare
@chencs Rebased PR and adjusted changelog as requested. |
8847a67
to
e2d2511
Compare
7982540
to
e458bc3
Compare
I am not sure from whom should I request a review here and it does not seem possible to tag @grafana/mimir-maintainers team as a whole. Maybe @dimitarvdimitrov you could take a look as I have seen some of your work on mimirtool? If there is anything missing/wrong with this PR, please let me know. |
Thank you for your contribution, this looks very good! I just left a small nit about the changelog entry, waiting for confirmation there before merging. |
8b9291e
to
d153329
Compare
Thank you. |
@colega I checked the CI logs and I don't see how my changes could fail the TestInstantQuerySplittingCorrectness test . The test passes locally. On my local fork that test also failed but after I have rerun it, it passed OK: source. Is there any chance that those tests could be flaky and CI run dependant? Or there is indeed something off with the changes I am proposing? It seems I am not able to trigger a rerun for the failed ci / test (2,4) job. I have rebased the PR with main and force pushed which disabled the auto merge and it looks like CI needs another approval - sorry for that. |
… supported commands
Head branch was pushed to by a user without write access
d153329
to
fb5a7f6
Compare
Hey, yes, |
I think that the new merge experience got in a way again 😅 since the CI workflow is not running and must be approved again. |
What this PR does
Which issue(s) this PR fixes or relates to
There is a discussion opened by my team member: #10152 (comment) and I have created an issue from it: #10178. This PR addresses the issues he is facing.
Related PRs to the changes I am proposing:
Thanks for making such a great product and all the tooling around it! Working with mimir and mimirtool is a breeze and helps a lot with our monitoring setup. We have discovered the above limitations during optimising our stored metrics in mimir. For us the basic auth username configured on the nginx proxy that is in front of mimir does not match the tenant name to which we push metrics and that prevents us from using some of the subcommands but others work and with that PR all of them should be unified. The proposed changes should be backwards compatible so anyone using mimirtool shouldn't be forced to change the passed ENVS / flags.
Checklist
CHANGELOG.md
updated - the order of entries should be[CHANGE]
,[FEATURE]
,[ENHANCEMENT]
,[BUGFIX]
.about-versioning.md
updated with experimental features.