dashboards: fix latency comparison in "Mimir / Rollout Progress" (#10495

) * dashboards: fix latency comparison in "Mimir / Rollout Progress" The route matcher wasn't being applied if the gateway is enabled. Signed-off-by: Dimitar Dimitrov <[email protected]> * Add CHANGELOG.md entry Signed-off-by: Dimitar Dimitrov <[email protected]> --------- Signed-off-by: Dimitar Dimitrov <[email protected]>
grafana · Jan 22, 2025 · 77194ac · 77194ac
1 parent a041148
commit 77194ac
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 2 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -45,6 +45,7 @@
 
 * [BUGFIX] Dashboards: fix how we switch between classic and native histograms. #10018
 * [BUGFIX] Alerts: Ignore cache errors performing `delete` operations since these are expected to fail when keys don't exist. #10287
+* [BUGFIX] Dashboards: fix "Mimir / Rollout Progress" latency comparison when gateway is enabled. #10495
 
 ### Jsonnet
 

diff --git a/operations/mimir-mixin/dashboards/rollout-progress.libsonnet b/operations/mimir-mixin/dashboards/rollout-progress.libsonnet
@@ -6,8 +6,8 @@ local filename = 'mimir-rollout-progress.json';
   local config = $.queries {
     namespace_matcher: $.namespaceMatcher(),
     requests_per_second_metric: if $._config.gateway_enabled then $.queries.gateway.requestsPerSecondMetric else $.queries.distributor.requestsPerSecondMetric,
-    write_job_selector: if $._config.gateway_enabled then $.jobSelector($._config.job_names.gateway) else $.jobSelector($._config.job_names.distributor) + [utils.selector.re('route', $.queries.write_http_routes_regex)],
-    read_job_selector: if $._config.gateway_enabled then $.jobSelector($._config.job_names.gateway) else $.jobSelector($._config.job_names.query_frontend) + [utils.selector.re('route', $.queries.read_http_routes_regex)],
+    write_job_selector: (if $._config.gateway_enabled then $.jobSelector($._config.job_names.gateway) else $.jobSelector($._config.job_names.distributor)) + [utils.selector.re('route', $.queries.write_http_routes_regex)],
+    read_job_selector: (if $._config.gateway_enabled then $.jobSelector($._config.job_names.gateway) else $.jobSelector($._config.job_names.query_frontend)) + [utils.selector.re('route', $.queries.read_http_routes_regex)],
     workload_label_replace_open:
       std.repeat('label_replace(', std.length($._config.rollout_dashboard.workload_label_replaces)),
     workload_label_replace_close: