tsdb: Add MustIndex() function to Head #811
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
colega
reviewed
Dec 26, 2024
tsdb/head_read.go
Outdated
Comment on lines
40
to
43
| func (h *Head) MustIndex() IndexReader { | ||
| return h.indexRange(math.MinInt64, math.MaxInt64) | ||
| } | ||
|
|
There was a problem hiding this comment.
Nit, we don't have a policy on this yet, but can you create a new file, called head_read_mimir.go and put this method there? This way we'll avoid a bunch of confclicting updates with upstream in the future.
There was a problem hiding this comment.
addressed in 7a70886
colega
reviewed
Dec 26, 2024
tsdb/head_read_test.go
Outdated
Comment on lines
431
to
433
|
|
||
| irMust := h.MustIndex() | ||
| require.Equal(t, irMust, ir) |
There was a problem hiding this comment.
This should go in a separate test (also as noted above, in a separate file)
There was a problem hiding this comment.
addressed in 7a70886
colega
reviewed
Jan 2, 2025
CHANGELOG.md
Outdated
| @@ -4,6 +4,7 @@ | |||
|
|
|||
| * [CHANGE] Notifier: Increment the prometheus_notifications_errors_total metric by the number of affected alerts rather than by one per batch of affected alerts. #15428 | |||
| * [ENHANCEMENT] OTLP receiver: Convert also metric metadata. #15416 | |||
| * [ENHANCEMENT] Introduced MustIndex() as a variant of Index() in tsdb Head that does not return an error. #811 | |||
There was a problem hiding this comment.
We don't update the changelog in mimir-prometheus, please remove this, otherwise it will be just a source of merge conflicts in the future.
colega
approved these changes
Jan 2, 2025
|
Approved modulo the changelog nit, please address it before merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the context of cost attribution in this PR #10269, I need to retrieve the index to decrement the active series count when a series goes out of the 20-minute active series window. Since the current Index() function does not return an error, we propose introducing a new function, MustIndex(), which will never return an error. Additionally, I will add tests to ensure that both functions return the same results.