fix(s3config): Accept S3 URL as url escaped. #8455
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes: #1607 Introduced this type in another PR grafana/dskit#265
kavirajk
commented
Feb 7, 2023
go.mod
Outdated
| @@ -48,7 +48,7 @@ require ( | |||
| github.com/gorilla/mux v1.8.0 | |||
| github.com/gorilla/websocket v1.5.0 | |||
| github.com/grafana/cloudflare-go v0.0.0-20230110200409-c627cf6792f2 | |||
| github.com/grafana/dskit v0.0.0-20230201083518-528d8a7d52f2 | |||
| github.com/grafana/dskit v0.0.0-20230207212244-6b8c28bc192e | |||
There was a problem hiding this comment.
Will update the hash once dskit PR got merged.
grafana/dskit#265
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Sometimes we need to store just escaped URL in the config like S3 URL that contains credentials which can include characters like
:and/. Currently we cannot use normalflagext.URLValueas it just uses unescaped URL.Introduced this type in another PR
grafana/dskit#265
Which issue(s) this PR fixes:
Fixes #1607
Special notes for your reviewer:
Checklist
CONTRIBUTING.mdguide (required)CHANGELOG.mdupdateddocs/sources/upgrading/_index.md