feat(helm): allow configuration of service trafficDistribution parameter #19558
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Allow configuration of service
trafficDistributionparameterWhich issue(s) this PR fixes:
Fixes #19557
Special notes for your reviewer:
While this is about exposing a simple Kubernetes service parameter .... Looking at this again, after having just pushed a PR implementing this, I am wondering if
trafficDistributioneven helps in reducing the cross-AZ traffic:Looking at https://grafana.com/docs/loki/latest/get-started/architecture/#loki-architecture ...
Write-Path - Ingesters are addressed via hashing of the log streams (https://grafana.com/docs/loki/latest/get-started/architecture/#write-path) and don't care about the service Endpoints?
Read-Path - Queries come in to the query-frontends and then go to the queriers and ingesters (for very recent data).
Do the frontends actually use the service endpoints or also use the hash, again distributing queries to all instances in all AZs?
I also found an old issue, Availability zone local replication #5319, discussing exactly what I am trying to achieve: save on VERY expensive cross-AZ traffic.
Checklist
CONTRIBUTING.mdguide (required)featPRs are unlikely to be accepted unless a case can be made for the feature actually being a bug fix to existing behavior.docs/sources/setup/upgrade/_index.mddeprecated-config.yamlanddeleted-config.yamlfiles respectively in thetools/deprecated-config-checkerdirectory. Example PR