chore: extend query blocking capabilities #19551
Merged
+211
−11
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
💻 Deploy preview deleted (chore: extend query blocking capabilities). |
JStickler
reviewed
Oct 22, 2025
| - pattern: '.*' # optional; if pattern and regex are omittied they will default to '.*' and true | ||
| regex: true | ||
| tags: | ||
| source: grafana |
There was a problem hiding this comment.
I think the tags need some explanation. The current examples could be misunderstood to mean that this pattern is a beta feature.
There was a problem hiding this comment.
Ah, reading further I see that is exactly what you're doing, blocking queries for a beta feature. Never mind...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Loki understands key=value pairs being passed via the X-Query-Tags header and will already log these in important log lines like query execution. This PR extends blocking functionality to be able to block queries based on these key=value pairs.
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Checklist
CONTRIBUTING.mdguide (required)featPRs are unlikely to be accepted unless a case can be made for the feature actually being a bug fix to existing behavior.docs/sources/setup/upgrade/_index.mddeprecated-config.yamlanddeleted-config.yamlfiles respectively in thetools/deprecated-config-checkerdirectory. Example PR