-
Notifications
You must be signed in to change notification settings - Fork 3.8k
fix(operator): set ingester minimum available pods based on replication factor #19517
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
Bayan Taani seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. You have signed the CLA already but the status is still pending? Let us recheck it. |
| } | ||
| } | ||
|
|
||
| func GetPDBMinAvailable(opts Options) (error, intstr.IntOrString) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we could move this function inside newIngesterPodDisruptionBudget.
What this PR does / why we need it:
Set the default value of the ingester's PodDisruptionBudget's minimum available pods to the replication factor
Which issue(s) this PR fixes:
Fixes LOG-6715
Special notes for your reviewer:
Checklist
CONTRIBUTING.mdguide (required)featPRs are unlikely to be accepted unless a case can be made for the feature actually being a bug fix to existing behavior.docs/sources/setup/upgrade/_index.mddeprecated-config.yamlanddeleted-config.yamlfiles respectively in thetools/deprecated-config-checkerdirectory. Example PR