Skip to content

Conversation

@btaani
Copy link
Contributor

@btaani btaani commented Oct 16, 2025

What this PR does / why we need it:
Set the default value of the ingester's PodDisruptionBudget's minimum available pods to the replication factor

Which issue(s) this PR fixes:
Fixes LOG-6715

Special notes for your reviewer:

Checklist

  • Reviewed the CONTRIBUTING.md guide (required)
  • Documentation added
  • Tests updated
  • Title matches the required conventional commits format, see here
    • Note that Promtail is considered to be feature complete, and future development for logs collection will be in Grafana Alloy. As such, feat PRs are unlikely to be accepted unless a case can be made for the feature actually being a bug fix to existing behavior.
  • Changes that require user attention or interaction to upgrade are documented in docs/sources/setup/upgrade/_index.md
  • If the change is deprecating or removing a configuration option, update the deprecated-config.yaml and deleted-config.yaml files respectively in the tools/deprecated-config-checker directory. Example PR

@CLAassistant
Copy link

CLAassistant commented Oct 16, 2025

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
1 out of 2 committers have signed the CLA.

✅ btaani
❌ Bayan Taani


Bayan Taani seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

@btaani btaani changed the title operator: set ingester minimum available pods based on replication factor fix(operator): set ingester minimum available pods based on replication factor Oct 20, 2025
}
}

func GetPDBMinAvailable(opts Options) (error, intstr.IntOrString) {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we could move this function inside newIngesterPodDisruptionBudget.

@pull-request-size pull-request-size bot added size/L and removed size/M labels Oct 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants