Skip to content

Conversation

@JoaoBraveCoding
Copy link
Collaborator

What this PR does / why we need it:

Alert now triggers on Lokistacks that never reach the ReadyComponents condition

Which issue(s) this PR fixes:
https://issues.redhat.com/browse/LOG-7874

Special notes for your reviewer:

Checklist

  • Reviewed the CONTRIBUTING.md guide (required)
  • Documentation added
  • Tests updated
  • Title matches the required conventional commits format, see here
    • Note that Promtail is considered to be feature complete, and future development for logs collection will be in Grafana Alloy. As such, feat PRs are unlikely to be accepted unless a case can be made for the feature actually being a bug fix to existing behavior.
  • Changes that require user attention or interaction to upgrade are documented in docs/sources/setup/upgrade/_index.md
  • If the change is deprecating or removing a configuration option, update the deprecated-config.yaml and deleted-config.yaml files respectively in the tools/deprecated-config-checker directory. Example PR

@xperimental
Copy link
Collaborator

I wonder if it makes more sense to change the collector in internal/metrics to always produce the metric about the ready-condition, even if the condition is not actually in the .status.conditions list, maybe even extending this to all three of the "there can be only one" conditions (failed, pending, ready).

@JoaoBraveCoding
Copy link
Collaborator Author

I wonder if it makes more sense to change the collector in internal/metrics to always produce the metric about the ready-condition, even if the condition is not actually in the .status.conditions list, maybe even extending this to all three of the "there can be only one" conditions (failed, pending, ready).

Yup this was also the other idea I had to tackle this but I wasn't sure if I wasn't reflecting a status on the metrics that still wasn't reflected on the status of the Lokistack... but if you also think that's the best way forward then we can go with it

@JoaoBraveCoding
Copy link
Collaborator Author

Decided on a meeting that we should go ahead with @xperimental suggestion

@JoaoBraveCoding JoaoBraveCoding force-pushed the operator-fix-component-alert branch from 66f3243 to 8007b30 Compare October 22, 2025 14:44
@JoaoBraveCoding JoaoBraveCoding force-pushed the operator-fix-component-alert branch from 8007b30 to 5e8d23c Compare October 22, 2025 15:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants