feat: dedupe duplicate delete requests while loading them for processing in compactor #15852
+235
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paul1r
reviewed
Jan 21, 2025
| @@ -160,6 +161,29 @@ func (d *DeleteRequest) IsDeleted(entry retention.ChunkEntry) (bool, filter.Func | |||
| return true, ff | |||
| } | |||
|
|
|||
| func (d *DeleteRequest) IsDuplicate(o *DeleteRequest) (bool, error) { | |||
| if d.RequestID == o.RequestID || d.UserID != o.UserID || d.StartTime != o.StartTime || d.EndTime != o.EndTime { | |||
There was a problem hiding this comment.
Suggested change
| if d.RequestID == o.RequestID || d.UserID != o.UserID || d.StartTime != o.StartTime || d.EndTime != o.EndTime { | |
| if d.RequestID != o.RequestID || d.UserID != o.UserID || d.StartTime != o.StartTime || d.EndTime != o.EndTime { |
There was a problem hiding this comment.
i wasn't 100% certain on the request ID being equal or not, but it struck me as unusual having one equality test and 3 non-equality tests in the same block
There was a problem hiding this comment.
We would never have duplicates from the same request, so the equality check was meant for that. I have separated the equality and inequality checks and added a comment.
…cking for duplicate requests
paul1r
approved these changes
Jan 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
While loading delete requests for processing, we will look for duplicate delete requests and mark them as processed when we are done processing the loaded requests. This should avoid wasting resources in processing the same requests sent multiple times by the users.
Checklist