fix(block-scheduler): one job per partition (local branch copy) #15579
Conversation
github-actions
bot
added
the
type/docs
|
💻 Deploy preview available: https://deploy-preview-loki-15579-zb444pucvq-vp.a.run.app/docs/loki/latest/ |
|
|
||
| // find first job for this partition | ||
| nextJob := sort.Search(len(jobs), func(i int) bool { | ||
| return jobs[i].Job.Partition() >= job.Partition() |
There was a problem hiding this comment.
| return jobs[i].Job.Partition() >= job.Partition() | |
| return jobs[i].Job.Partition() == job.Partition() |
There was a problem hiding this comment.
That function probably works a bit different than you think :)
| }) | ||
|
|
||
| if nextJob < len(jobs) { | ||
| _, _, _ = s.idempotentEnqueue(jobs[nextJob]) |
There was a problem hiding this comment.
there is a potential race here that could result in this operation to fail as we try to enqueue the same job from two different routines (from HandleCompleteJob or from the scheduler run loop). but this might not cause any problems
There was a problem hiding this comment.
This should be ok since the enqueue code first checks the statusmap for existence of a job before adding it to the queue. We may need to introduce some error handling here or there to swallow these cases, but it shouldn't be possible to add duplicate jobs at the moment.
Local branch copy of #15578 to debug possible fork permission issues
max_jobs_planned_per_interval. We don't want this yet and it was being used incorrectly as the plannersmaxJobsPerPartitionargument.Some of it is a bit hacky & will need refactoring, but this should work well enough in the meantime to flesh out issues.