Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Karsten/benchmark engine #15558

Closed
wants to merge 7 commits into from

Conversation

jeschkies
Copy link
Contributor

@jeschkies jeschkies commented Dec 30, 2024

What this PR does / why we need it:

                               │ before.log  │              after.log              │
                               │   sec/op    │   sec/op     vs base                │
HeapCountMinSketchVectorAdd-16   425.4m ± 2%   357.7m ± 3%  -15.91% (p=0.000 n=10)

                               │  before.log   │              after.log               │
                               │     B/op      │     B/op      vs base                │
HeapCountMinSketchVectorAdd-16   12.098Mi ± 0%   2.627Mi ± 0%  -78.29% (p=0.000 n=10)

                               │ before.log  │             after.log              │
                               │  allocs/op  │  allocs/op   vs base               │
HeapCountMinSketchVectorAdd-16   116.9k ± 0%   108.8k ± 0%  -6.92% (p=0.000 n=10)

Special notes for your reviewer:

Checklist

  • Reviewed the CONTRIBUTING.md guide (required)
  • Documentation added
  • Tests updated
  • Title matches the required conventional commits format, see here
    • Note that Promtail is considered to be feature complete, and future development for logs collection will be in Grafana Alloy. As such, feat PRs are unlikely to be accepted unless a case can be made for the feature actually being a bug fix to existing behavior.
  • Changes that require user attention or interaction to upgrade are documented in docs/sources/setup/upgrade/_index.md
  • If the change is deprecating or removing a configuration option, update the deprecated-config.yaml and deleted-config.yaml files respectively in the tools/deprecated-config-checker directory. Example PR

@jeschkies jeschkies requested a review from a team as a code owner December 30, 2024 09:40
@jeschkies jeschkies changed the title ccunvkkehrgevfnhtgknhhhbtrcjfujievlgetliKarsten/benchmark engine Karsten/benchmark engine Dec 30, 2024
@pull-request-size pull-request-size bot added size/M and removed size/L labels Dec 30, 2024
@jeschkies
Copy link
Contributor Author

Replaced by #15559

@jeschkies jeschkies closed this Dec 30, 2024
@jeschkies jeschkies deleted the karsten/benchmark-engine branch December 30, 2024 09:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant