Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: add curl commands #15488

Merged
merged 2 commits into from
Jan 7, 2025
Merged

docs: add curl commands #15488

merged 2 commits into from
Jan 7, 2025

Conversation

JStickler
Copy link
Contributor

@JStickler JStickler commented Dec 18, 2024

What this PR does / why we need it:

Adds curl commands to procedure.

Which issue(s) this PR fixes:
Fixes #7478

Special notes for your reviewer:
@Jayclifford345 I just want to make sure that adding tabbed content will also work in the Killercoda tutorial.

TabbedContent

@JStickler JStickler added the type/docs Issues related to technical documentation; the Docs Squad uses this label across many repositories label Dec 18, 2024
@JStickler JStickler requested a review from a team as a code owner December 18, 2024 20:12
Copy link
Contributor

github-actions bot commented Dec 18, 2024

💻 Deploy preview deleted.

@Jayclifford345
Copy link
Contributor

Hi @JStickler,
At the moment we don't support it but I can add a ticket. We can easily get around it though by adding the following:

   <!-- INTERACTIVE ignore START -->
   {{< tabs >}}
   {{< tab-content name="wget" >}}
   ```bash
   wget https://raw.githubusercontent.com/grafana/loki/main/examples/getting-started/loki-config.yaml -O loki-config.yaml
   wget https://raw.githubusercontent.com/grafana/loki/main/examples/getting-started/alloy-local-config.yaml -O alloy-local-config.yaml
   wget https://raw.githubusercontent.com/grafana/loki/main/examples/getting-started/docker-compose.yaml -O docker-compose.yaml
   ```
   {{< /tab-content >}}
   {{< tab-content name="curl" >}}
   ```bash
   curl https://raw.githubusercontent.com/grafana/loki/main/examples/getting-started/loki-config.yaml --output loki-config.yaml
   curl https://raw.githubusercontent.com/grafana/loki/main/examples/getting-started/alloy-local-config.yaml --output alloy-local-config.yaml
   curl https://raw.githubusercontent.com/grafana/loki/main/examples/getting-started/docker-compose.yaml --output docker-compose.yaml
   ```
   {{< /tab-content >}}
   {{< /tabs >}}
 <!-- INTERACTIVE ignore END -->

{{< docs/ignore >}}
   ```bash
   wget https://raw.githubusercontent.com/grafana/loki/main/examples/getting-started/loki-config.yaml -O loki-config.yaml
   wget https://raw.githubusercontent.com/grafana/loki/main/examples/getting-started/alloy-local-config.yaml -O alloy-local-config.yaml
   wget https://raw.githubusercontent.com/grafana/loki/main/examples/getting-started/docker-compose.yaml -O docker-compose.yaml
   ```
{{< /docs/ignore >}}
 

Not the prettiest but this will force the transformer to ignore the tabbing for now but still leave a workable example for Killercoda to use. Then once we add the feature we can remove the meta-ignore jargon. Also tagging @jdbaldry so he is in the loop

Copy link
Contributor

@Jayclifford345 Jayclifford345 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See above comment :)

Copy link
Contributor

@Jayclifford345 Jayclifford345 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :)

@JStickler JStickler merged commit d8dc10f into main Jan 7, 2025
61 checks passed
@JStickler JStickler deleted the GH_7478 branch January 7, 2025 13:04
loki-gh-app bot pushed a commit that referenced this pull request Jan 7, 2025
(cherry picked from commit d8dc10f)
loki-gh-app bot pushed a commit that referenced this pull request Jan 7, 2025
(cherry picked from commit d8dc10f)
loki-gh-app bot pushed a commit that referenced this pull request Jan 7, 2025
(cherry picked from commit d8dc10f)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport release-3.1.x backport release-3.2.x backport release-3.3.x size/S type/docs Issues related to technical documentation; the Docs Squad uses this label across many repositories
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Docs feedback: /getting-started/_index.md
2 participants