Use non sparse HLL to avoid allocations

grafana · Dec 27, 2024 · 448aafe · 448aafe
1 parent 22835ff
commit 448aafe
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 3 deletions.
diff --git a/pkg/logql/count_min_sketch.go b/pkg/logql/count_min_sketch.go
@@ -241,9 +241,8 @@ func (v *HeapCountMinSketchVector) Push(x any) {
 func (v *HeapCountMinSketchVector) Pop() any {
 	old := v.Metrics
 	n := len(old)
-	x := old[n-1]
 	v.Metrics = old[0 : n-1]
-	return x
+	return old[n-1]
 }
 
 // JoinCountMinSketchVector joins the results from stepEvaluator into a CountMinSketchVector.

diff --git a/pkg/logql/sketch/cms.go b/pkg/logql/sketch/cms.go
@@ -19,7 +19,7 @@ func NewCountMinSketch(w, d uint32) (*CountMinSketch, error) {
 		Depth:       d,
 		Width:       w,
 		Counters:    make2dslice(w, d),
-		HyperLogLog: hyperloglog.New16(),
+		HyperLogLog: hyperloglog.New16NoSparse(),
 	}, nil
 }