Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix k6 permission in docker image #5

Merged
merged 4 commits into from
Oct 7, 2024

Conversation

szkiba
Copy link
Collaborator

@szkiba szkiba commented Oct 7, 2024

Fixes

  • The executable bit of the k6 binary was removed for some reason while copying to the Docker image. Now the executable bit is explicitly set during copying.

Refactors

  • GitHub Action input environment variables are now handled automatically based on the command flag. The name of the environment variable is generated from the name of the flag. In this way, all environment variables belonging to flags are processed.

  • The GitHub Action parameter corresponding to the positional argument is now args, i.e. the corresponding environment variable INPUT_ARGS. Its value is split using the shlex package.

@szkiba szkiba requested a review from a team as a code owner October 7, 2024 07:46
@szkiba szkiba requested review from pablochacin and removed request for a team October 7, 2024 07:46
@szkiba szkiba linked an issue Oct 7, 2024 that may be closed by this pull request
@szkiba szkiba removed the request for review from pablochacin October 7, 2024 07:46
@szkiba szkiba merged commit 8d06286 into main Oct 7, 2024
5 checks passed
@szkiba szkiba deleted the 4-fix-k6-permission-in-docker-image branch October 7, 2024 07:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix k6 permission in Docker image
1 participant