Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump go version #4606

Merged
merged 3 commits into from
Mar 10, 2025
Merged

Bump go version #4606

merged 3 commits into from
Mar 10, 2025

Conversation

mstoykov
Copy link
Contributor

@mstoykov mstoykov commented Mar 6, 2025

What?

Update k6 to use go 1.23 and 1.24 instead of 1.22 and 1.23.

This bumps us to the currently supported by the golang team go versions

Why?

We already have PRs #4601 that are blocked on us still using 1.22 in some places.

Also go 1.24.1 has been released with a number of bugfixes and CVE fix that is only available for 1.23.+

Checklist

  • I have performed a self-review of my code.
  • I have commented on my code, particularly in hard-to-understand areas.
  • I have added tests for my changes.
  • I have run linter and tests locally (make check) and all pass.

Checklist: Documentation (only for k6 maintainers and if relevant)

Please do not merge this PR until the following items are filled out.

  • I have added the correct milestone and labels to the PR.
  • I have updated the k6-documentation: grafana/k6-docs#PR-NUMBER
  • I have updated the TypeScript definitions: grafana/k6-DefinitelyTyped#PR-NUMBER
  • I have updated the release notes: link

Related PR(s)/Issue(s)

@mstoykov mstoykov added this to the v1.0.0-rc1 milestone Mar 6, 2025
@mstoykov mstoykov requested a review from a team as a code owner March 6, 2025 10:30
@mstoykov mstoykov requested review from inancgumus and joanlopez and removed request for a team March 6, 2025 10:30
joanlopez
joanlopez previously approved these changes Mar 6, 2025
olegbespalov
olegbespalov previously approved these changes Mar 7, 2025
Base automatically changed from bumpGolangci to master March 7, 2025 14:52
@mstoykov mstoykov dismissed stale reviews from olegbespalov and joanlopez March 7, 2025 14:52

The base branch was changed.

@mstoykov mstoykov merged commit f033232 into master Mar 10, 2025
27 of 28 checks passed
@mstoykov mstoykov deleted the BumpGoVersion branch March 10, 2025 08:31
@Fernando-hub527
Copy link

Hi!
After updating my branch based on master, I noticed that the test below was failing. Looking back through some commits, I found that the test started failing after this PR was added. I'm still investigating, but if you have any tips on possible causes, I'd appreciate it!
Captura de tela de 2025-03-11 20-36-04

@mstoykov
Copy link
Contributor Author

@Fernando-hub527 this looks more like a flaky test and unlikely to have anything to do with bumping the go version.

Please if you want to report an issue do open a new one 🙇

@Fernando-hub527
Copy link

@Fernando-hub527 this looks more like a flaky test and unlikely to have anything to do with bumping the go version.

Please if you want to report an issue do open a new one 🙇

Alright, I'll investigate the issue further and try to understand what's causing this instability.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants