feat: Save generators without file dialog #77
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
going-confetti
commented
Aug 1, 2024
|
|
||
| export function Generator() { | ||
| const name = useGeneratorStore((store) => store.name) | ||
| const filteredRequests = useGeneratorStore(selectFilteredRequests) | ||
| const hasRecording = useGeneratorStore(selectHasRecording) | ||
| const [isLoading, setIsLoading] = useState(false) | ||
| const { path } = useParams() | ||
| invariant(path, 'Path is required') |
There was a problem hiding this comment.
Common frontend implementation of the assert pattern. Looks concise and helps to narrow the type
going-confetti
commented
Aug 1, 2024
|
|
||
| const handleEdit = () => { | ||
| selectRule(ruleId) | ||
| navigate(`/generator/rule/${ruleId}`) | ||
| navigate(`/generator/${encodeURIComponent(path)}/rule/${ruleId}`) |
There was a problem hiding this comment.
Apparently the previous PR broke this :\
We should probably start using functions to build paths like we do in GCk6
Llandy3d
approved these changes
Aug 1, 2024
| if (!har) { | ||
| return | ||
| } | ||
| invariant(har, 'Failed to open file') |
There was a problem hiding this comment.
not convinced on the invariant use on this, feels like we should just better handle the error case, but let's discuss it in the tech retro
There was a problem hiding this comment.
Yes, definitely! This should never actually fire, but in general, invariant is just a "wrapper" for
if (!value) {
throw new Error(message)
}So it will be caught by whatever error handlers we'll be adding over the course of the upcoming weeks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.