feat: Route-based nav #74
Conversation
There was a problem hiding this comment.
View meant exclusively for previewing existing recordings.
|
|
||
| export function createNewGeneratorFile(recordingPath = ''): GeneratorFileData { | ||
| return { | ||
| name: 'New test generator', |
There was a problem hiding this comment.
Do we actually need this field? Feels like we can always use the filename instead
There was a problem hiding this comment.
We might want to have it if filename can be different than Generator name and we want to allow forbidden characters on filenames.
We don't have to necessarily show the filename in the app but we can always show the assigned name
There was a problem hiding this comment.
On the other hand, if we end up suggesting git as the way to version control, organize, and share the studio assets, knowing the filename will be important. I'll add a question for the next WG meeting
| @@ -19,7 +17,6 @@ export const useStudioUIStore = create<StudioUIStore>()( | |||
| recordings: [], | |||
| generators: [], | |||
| scripts: [], | |||
| selectedFile: null, | |||
There was a problem hiding this comment.
The route params are the source of truth now, so this is not needed.
There was a problem hiding this comment.
No need for this to be a store, as the data is only used within one view. Having a store actually complicates things a bit as you need to remember to reset the data on navigating to and from Recorder/Validator.
I moved the functionality to useListenProxyData
|
|
||
| export function createNewGeneratorFile(recordingPath = ''): GeneratorFileData { | ||
| return { | ||
| name: 'New test generator', |
There was a problem hiding this comment.
We might want to have it if filename can be different than Generator name and we want to allow forbidden characters on filenames.
We don't have to necessarily show the filename in the app but we can always show the assigned name
No description provided.