Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Renaming generator with unsaved changes creates extra file #534

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

fix: Renaming generator with unsaved changes creates extra file #534

wants to merge 2 commits into from
+27 −3

Conversation

going-confetti
Copy link
Collaborator

@going-confetti going-confetti commented Mar 7, 2025 •
edited
Loading

Closes #506

Description

How to Test

  1. Open a generator
  2. Change its configuration (the easiest thing to do might be disabling a rule)
  3. Try renaming the file - it should work without creating an extra file

@going-confetti going-confetti requested a review from Llandy3d March 7, 2025 15:47
Llandy3d
Llandy3d previously approved these changes Mar 7, 2025
View reviewed changes
Copy link
Member

@Llandy3d Llandy3d left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems to be working perfectly 🙌

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Llandy3d Llandy3d Llandy3d left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Renaming an unsaved Generator ends up with two Generators file
2 participants
@going-confetti @Llandy3d