Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Caret icon doesn't change state in Validator dialog #391

Merged
merged 1 commit into from
Dec 30, 2024
Merged

fix: Caret icon doesn't change state in Validator dialog #391

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/components/Collapsible.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@ const Header = styled.div`
const CaretIcon = styled(CaretRightIcon)`
transform: rotate(0deg);

[data-state='open'] & {
button[data-state='open'] & {
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since there's a dialog with data-state="open", this was always true

transform: rotate(90deg);
}
`
Expand Down
1 change: 0 additions & 1 deletion src/components/WebLogView/WebLogView.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,6 @@ import { useDeepCompareEffect } from 'react-use'
interface WebLogViewProps {
requests: ProxyDataWithMatches[]
groups?: GroupType[]
activeGroup?: string
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unused prop

selectedRequestId?: string
onSelectRequest: (data: ProxyDataWithMatches | null) => void
onUpdateGroup?: (group: GroupType) => void
Expand Down
1 change: 0 additions & 1 deletion src/views/Recorder/Recorder.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -212,7 +212,6 @@ export function Recorder() {
selectedRequestId={selectedRequest?.id}
autoScroll
groups={groups}
activeGroup={group?.id}
onSelectRequest={setSelectedRequest}
onUpdateGroup={handleUpdateGroup}
resetProxyData={handleResetRecording}
Expand Down
3 changes: 0 additions & 3 deletions src/views/Recorder/RequestsSection.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,6 @@ interface RequestsSectionProps {
groups?: Group[]
selectedRequestId?: string
autoScroll?: boolean
activeGroup?: string
noDataElement?: ReactNode
onSelectRequest: (data: ProxyData | null) => void
onUpdateGroup?: (group: Group) => void
Expand All @@ -29,7 +28,6 @@ export function RequestsSection({
noDataElement,
autoScroll = false,
groups,
activeGroup,
onSelectRequest,
onUpdateGroup,
resetProxyData,
Expand Down Expand Up @@ -90,7 +88,6 @@ export function RequestsSection({
<WebLogView
requests={filteredRequests}
groups={groups}
activeGroup={activeGroup}
selectedRequestId={selectedRequestId}
onSelectRequest={onSelectRequest}
onUpdateGroup={onUpdateGroup}
Expand Down
Loading