chore: Use tanstack query for settings #384
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
going-confetti
commented
Dec 18, 2024
Comment on lines
+48
to
51
| <Flex align="center"> | ||
| <Spinner mr="2" /> | ||
| <Text size="2"> | ||
| k6 Studio logs in this screen are updated in real-time. | ||
| <Text size="2" color="gray"> | ||
| Application logs are updated in real-time. | ||
| </Text> | ||
| </Flex> |
There was a problem hiding this comment.
I made it a bit more subtle, but I'm not quite happy with the spinner here: IMO it gives an indication that something is constantly fetching, even though it's not the case.
| @@ -65,23 +60,6 @@ export const SettingsDialog = ({ open, onOpenChange }: SettingsDialogProps) => { | |||
| formState: { isDirty, errors }, | |||
| } = formMethods | |||
|
|
|||
| const onSubmit = async (data: AppSettings) => { | |||
There was a problem hiding this comment.
using tanstack query is more ergonomic and allows us to reused cached settings across different components
going-confetti
requested review from
cristianoventura and
e-fisher
and removed request for
a team
going-confetti
commented
Dec 18, 2024
There was a problem hiding this comment.
Not related to this PR, but I think it'd be really nice to add basic syntax highlighting to logs
going-confetti
force-pushed
the
chore/usequery-settings
branch
from
aff57f7 to
5eec434
Compare
allansson
approved these changes
Dec 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
How to Test
Checklist
npm run lint) and all checks pass.npm test) and all tests pass.Screenshots (if appropriate):
Related PR(s)/Issue(s)