chore: Stricter ESLint config

.eslintrc.cjs

@@ -7,7 +7,7 @@ module.exports = {
   extends: [
     'eslint:recommended',
     'plugin:@typescript-eslint/eslint-recommended',
-    'plugin:@typescript-eslint/recommended',
+    'plugin:@typescript-eslint/recommended-type-checked',
     'plugin:import/recommended',
     'plugin:import/electron',
     'plugin:import/typescript',
@@ -18,7 +18,11 @@ module.exports = {
     'prettier',
   ],
   parser: '@typescript-eslint/parser',
-  ignorePatterns: ['resources/group_snippet.js', 'install-k6.js'],
+  ignorePatterns: [
+    'resources/group_snippet.js',
+    'install-k6.js',
+    '.eslintrc.cjs',
+  ],
   plugins: [
     'import',
     'unused-imports',
@@ -43,11 +47,8 @@ module.exports = {
         argsIgnorePattern: '^_',
       },
     ],
-    // TODO: remove warnings when plugin:@typescript-eslint/recommended-type-checked is enabled
-    '@typescript-eslint/no-unsafe-assignment': 'warn',
-    '@typescript-eslint/no-unsafe-return': 'warn',
-    '@typescript-eslint/no-unsafe-argument': 'warn',
-    '@typescript-eslint/no-unsafe-member-access': 'warn',
+    '@typescript-eslint/no-floating-promises': 'off',
+    '@typescript-eslint/no-misused-promises': 'off',
   },
 
   parserOptions: {

src/codegen/codegen.utils.ts

@@ -24,6 +24,8 @@ export function stringify(value: unknown): string {
     return `{${properties}}`
   }
 
+  // TODO: https://github.com/grafana/k6-studio/issues/277
+  // eslint-disable-next-line @typescript-eslint/restrict-template-expressions
   return `${value}`
 }
 

src/components/Form/FileUploadInput.tsx

@@ -39,6 +39,8 @@ export const FileUploadInput = ({
               disabled={disabled}
               onChange={field.onChange}
               name={field.name}
+              // TODO: https://github.com/grafana/k6-studio/issues/277
+              // eslint-disable-next-line @typescript-eslint/no-unsafe-assignment
               value={field.value}
             />
           </FieldGroup>

src/components/WebLogView/RequestDetails/utils.ts

@@ -28,6 +28,8 @@ export function parseParams(data: ProxyData) {
     }
 
     return stringify(
+      // TODO: https://github.com/grafana/k6-studio/issues/277
+      // eslint-disable-next-line @typescript-eslint/no-unsafe-argument
       JSON.parse(jsonrepair(parsePythonByteString(contentDecoded)))
     )
   } catch (e) {

src/components/WebLogView/ResponseDetails/Preview.tsx

@@ -53,6 +53,8 @@ export function Preview({ content, contentType, format }: PreviewProps) {
     return (
       <ReactJson
         shouldCollapse={(field) => field.name !== 'root'}
+        // TODO: https://github.com/grafana/k6-studio/issues/277
+        // eslint-disable-next-line @typescript-eslint/no-unsafe-assignment
         src={JSON.parse(content)}
         theme={theme === 'dark' ? 'monokai' : 'rjv-default'}
         style={theme === 'dark' ? reactJsonDarkStyles : reactJsonLightStyles}

src/components/WebLogView/ResponseDetails/ResponseDetails.utils.ts

@@ -49,8 +49,12 @@ export function parseContent(format: string | undefined, data: ProxyData) {
   try {
     switch (format) {
       case 'json':
+        // TODO: https://github.com/grafana/k6-studio/issues/277
+        // eslint-disable-next-line @typescript-eslint/no-unsafe-argument
         return stringify(JSON.parse(safeAtob(content)))
       case 'json-raw':
+        // TODO: https://github.com/grafana/k6-studio/issues/277
+        // eslint-disable-next-line @typescript-eslint/no-unsafe-argument
         return stringify(JSON.parse(safeAtob(content)), 0)
       case 'css':
       case 'html':

src/hooks/useRunChecks.test.ts

@@ -41,7 +41,7 @@ describe('useRunChecks', () => {
       createK6Check({ id: '1', name: 'Check 1' }),
       createK6Check({ id: '2', name: 'Check 2' }),
     ]
-    onScriptCheck.mockImplementation((callback) => {
+    onScriptCheck.mockImplementation((callback: (data: K6Check[]) => void) => {
       callback(mockChecks)
       return () => {}
     })

src/hooks/useRunLogs.test.ts

@@ -3,6 +3,7 @@ import { useRunLogs } from './useRunLogs'
 import { renderHook } from '@testing-library/react'
 import { act } from 'react'
 import { beforeAll, beforeEach, describe, expect, it, vi } from 'vitest'
+import { K6Log } from '@/types'
 
 const onScriptLog = vi.fn()
 
@@ -37,7 +38,7 @@ describe('useRunLogs', () => {
 
   it('should update logs when onScriptLog is called', () => {
     const mockLog = createK6Log()
-    onScriptLog.mockImplementation((callback) => {
+    onScriptLog.mockImplementation((callback: (log: K6Log) => void) => {
       callback(mockLog)
       return () => {}
     })

src/hooks/useScriptPreview.test.ts

@@ -16,7 +16,7 @@ import {
 } from '@/test/factories/generator'
 
 vi.mock('lodash-es', () => ({
-  debounce: vi.fn((fn) => fn),
+  debounce: vi.fn((fn: () => void) => fn),
 }))
 vi.mock('@/store/generator', () => ({
   useGeneratorStore: {

src/main.ts

@@ -113,7 +113,7 @@ const createSplashWindow = async () => {
     splashscreenWindow.webContents.openDevTools({ mode: 'detach' })
   }
 
-  splashscreenWindow.loadFile(splashscreenFile)
+  await splashscreenWindow.loadFile(splashscreenFile)
 
   // wait for the window to be ready before showing it. It prevents showing a white page on longer load times.
   splashscreenWindow.once('ready-to-show', () => {
@@ -231,7 +231,7 @@ app.on('before-quit', async () => {
   stopProxyProcess()
 })
 
-ipcMain.handle('app:change-route', async (_, route: string) => {
+ipcMain.handle('app:change-route', (_, route: string) => {
   currentClientRoute = route
 })
 
@@ -255,9 +255,9 @@ ipcMain.handle('proxy:start', async (event) => {
   currentProxyProcess = await launchProxyAndAttachEmitter(browserWindow)
 })
 
-ipcMain.on('proxy:stop', async () => {
+ipcMain.on('proxy:stop', () => {
   console.info('proxy:stop event received')
-  stopProxyProcess()
+  return stopProxyProcess()
 })
 
 const waitForProxy = async (): Promise<void> => {
@@ -286,7 +286,7 @@ ipcMain.handle('browser:start', async (event, url?: string) => {
 ipcMain.on('browser:stop', async () => {
   console.info('browser:stop event received')
   if (currentBrowserProcess) {
-    currentBrowserProcess.close()
+    await currentBrowserProcess.close()
     currentBrowserProcess = null
   }
 })
@@ -415,8 +415,12 @@ ipcMain.handle('har:open', async (_, fileName: string): Promise<HarFile> => {
   try {
     fileHandle = await open(path.join(RECORDINGS_PATH, fileName), 'r')
     const data = await fileHandle?.readFile({ encoding: 'utf-8' })
+    // TODO: https://github.com/grafana/k6-studio/issues/277
+    // eslint-disable-next-line @typescript-eslint/no-unsafe-assignment
     const har = await JSON.parse(data)
 
+    // TODO: https://github.com/grafana/k6-studio/issues/277
+    // eslint-disable-next-line @typescript-eslint/no-unsafe-assignment
     return { name: fileName, content: har }
   } finally {
     await fileHandle?.close()
@@ -470,8 +474,12 @@ ipcMain.handle(
       fileHandle = await open(path.join(GENERATORS_PATH, fileName), 'r')
 
       const data = await fileHandle?.readFile({ encoding: 'utf-8' })
+      // TODO: https://github.com/grafana/k6-studio/issues/277
+      // eslint-disable-next-line @typescript-eslint/no-unsafe-assignment
       const generator = await JSON.parse(data)
 
+      // TODO: https://github.com/grafana/k6-studio/issues/277
+      // eslint-disable-next-line @typescript-eslint/no-unsafe-assignment
       return { name: fileName, content: generator }
     } finally {
       await fileHandle?.close()
@@ -490,7 +498,7 @@ ipcMain.handle('ui:delete-file', async (_, fileName: string) => {
   return unlink(getFilePathFromName(fileName))
 })
 
-ipcMain.on('ui:open-folder', async (_, fileName: string) => {
+ipcMain.on('ui:open-folder', (_, fileName: string) => {
   console.info('ui:open-folder event received')
   shell.showItemInFolder(getFilePathFromName(fileName))
 })
@@ -610,7 +618,7 @@ ipcMain.handle('settings:select-upstream-certificate', async () => {
   return selectUpstreamCertificate()
 })
 
-ipcMain.handle('proxy:status:get', async () => {
+ipcMain.handle('proxy:status:get', () => {
   console.info('proxy:status:get event received')
   return proxyStatus
 })

src/preload.ts

@@ -1,3 +1,5 @@
+// TODO: https://github.com/grafana/k6-studio/issues/277
+/* eslint-disable @typescript-eslint/no-unsafe-return */
 import { ipcRenderer, contextBridge, IpcRendererEvent } from 'electron'
 import { ProxyData, K6Log, K6Check, ProxyStatus } from './types'
 import { HarFile } from './types/har'
@@ -34,7 +36,7 @@ const proxy = {
   onProxyData: (callback: (data: ProxyData) => void) => {
     return createListener('proxy:data', callback)
   },
-  getProxyStatus: () => {
+  getProxyStatus: (): Promise<ProxyStatus> => {
     return ipcRenderer.invoke('proxy:status:get')
   },
   onProxyStatusChange: (callback: (status: ProxyStatus) => void) => {

src/proxy.ts

@@ -94,7 +94,7 @@ export const launchProxy = (
   })
 
   proxy.stderr.on('data', (data: Buffer) => {
-    console.error(`stderr: ${data}`)
+    console.error(`stderr: ${data.toString()}`)
     log.error(data.toString())
   })
 

src/rules/correlation.ts

@@ -61,7 +61,7 @@ function applyRule({
   requestSnippetSchema: RequestSnippetSchema
   state: CorrelationState
   rule: CorrelationRule
-  idGenerator: Generator<number>
+  idGenerator: IdGenerator
   setState: (newState: Partial<CorrelationState>) => void
 }) {
   // this is the modified schema that we return to the accumulator
@@ -108,6 +108,8 @@ function applyRule({
   }
 
   // try to extract the value
+  // TODO: https://github.com/grafana/k6-studio/issues/277
+  // eslint-disable-next-line @typescript-eslint/no-unsafe-assignment
   const { extractedValue, generatedUniqueId, correlationExtractionSnippet } =
     tryCorrelationExtraction(
       rule,
@@ -126,7 +128,9 @@ function applyRule({
     }
 
     setState({
-      extractedValue: extractedValue,
+      // TODO: https://github.com/grafana/k6-studio/issues/277
+      // eslint-disable-next-line @typescript-eslint/no-unsafe-assignment
+      extractedValue,
       generatedUniqueId: generatedUniqueId,
       responsesExtracted: [
         ...state.responsesExtracted,
@@ -542,9 +546,14 @@ const extractCorrelationJsonBody = (
     return noCorrelationResult
   }
 
+  // TODO: https://github.com/grafana/k6-studio/issues/277
+  // eslint-disable-next-line @typescript-eslint/no-unsafe-assignment
   const extractedValue = getJsonObjectFromPath(response.content, selector.path)
 
-  if (!extractedValue || extractedValue.length === 0) {
+  if (
+    !extractedValue ||
+    (Array.isArray(extractedValue) && extractedValue.length === 0)
+  ) {
     return noCorrelationResult
   }
 
@@ -558,6 +567,8 @@ const extractCorrelationJsonBody = (
   const correlationExtractionSnippet = `
 correlation_vars['correlation_${generatedUniqueId}'] = resp.json()${json_path}`
   return {
+    // TODO: https://github.com/grafana/k6-studio/issues/277
+    // eslint-disable-next-line @typescript-eslint/no-unsafe-assignment
     extractedValue,
     correlationExtractionSnippet,
     generatedUniqueId,

src/rules/parameterization.ts

@@ -10,7 +10,7 @@ import { matchFilter } from './utils'
 
 export function createParameterizationRuleInstance(
   rule: ParameterizationRule,
-  idGenerator: Generator<number>
+  idGenerator: Generator<number, number, number>
 ): ParameterizationRuleInstance {
   const state: ParameterizationState = {
     requestsReplaced: [],

src/rules/rules.ts

@@ -8,7 +8,10 @@ import { ProxyData, RequestSnippetSchema } from '@/types'
 import { generateSequentialInt } from './utils'
 
 function createSequentialIdPool() {
-  const currentId: Record<TestRule['type'], Generator<number>> = {
+  const currentId: Record<
+    TestRule['type'],
+    Generator<number, number, number>
+  > = {
     correlation: generateSequentialInt(),
     parameterization: generateSequentialInt(),
     verification: generateSequentialInt(),
@@ -37,7 +40,7 @@ export function applyRules(recording: ProxyData[], rules: TestRule[]) {
 
 function createRuleInstance<T extends TestRule>(
   rule: T,
-  idGenerator: Generator<number>
+  idGenerator: Generator<number, number, number>
 ) {
   switch (rule.type) {
     case 'correlation':

src/rules/shared.ts

@@ -116,6 +116,8 @@ export const matchRegex = (value: string, regexString: string) => {
 }
 
 export const getJsonObjectFromPath = (json: string, path: string) => {
+  // TODO: https://github.com/grafana/k6-studio/issues/277
+  // eslint-disable-next-line @typescript-eslint/no-unsafe-return
   return get(safeJsonParse(json), path)
 }
 
@@ -272,6 +274,8 @@ export const replaceJsonBody = (
 
   // since we are using lodash and its `set` function creates missing paths we will first check that the path really
   // exists before setting it
+  // TODO: https://github.com/grafana/k6-studio/issues/277
+  // eslint-disable-next-line @typescript-eslint/no-unsafe-assignment
   const valueToReplace = getJsonObjectFromPath(request.content, selector.path)
   if (!valueToReplace) return
 

src/script.ts

@@ -83,11 +83,15 @@ export const runScript = async (
   stdoutReader.on('line', (data) => {
     console.log(`stdout: ${data}`)
 
+    // TODO: https://github.com/grafana/k6-studio/issues/277
+    // eslint-disable-next-line @typescript-eslint/no-unsafe-assignment
     const checkData: K6Check[] = JSON.parse(data)
     browserWindow.webContents.send('script:check', checkData)
   })
 
   stderrReader.on('line', (data) => {
+    // TODO: https://github.com/grafana/k6-studio/issues/277
+    // eslint-disable-next-line @typescript-eslint/no-unsafe-assignment
     const logData: K6Log = JSON.parse(data)
     browserWindow.webContents.send('script:log', logData)
   })

src/settings.ts

@@ -55,7 +55,11 @@ export async function getSettings() {
   const fileHandle = await open(filePath, 'r')
   try {
     const settings = await fileHandle?.readFile({ encoding: 'utf-8' })
+    // TODO: https://github.com/grafana/k6-studio/issues/277
+    // eslint-disable-next-line @typescript-eslint/no-unsafe-assignment
     const currentSettings = JSON.parse(settings)
+    // TODO: https://github.com/grafana/k6-studio/issues/277
+    // eslint-disable-next-line @typescript-eslint/no-unsafe-assignment
     const allSettings = {
       ...defaultSettings,
       ...currentSettings,

src/utils/format.ts

@@ -1,7 +1,11 @@
 export function queryStringToJSON(str: string) {
+  // TODO: https://github.com/grafana/k6-studio/issues/277
+  // eslint-disable-next-line @typescript-eslint/no-unsafe-return
   return JSON.parse(
     '{"' + str.replace(/&/g, '","').replace(/=/g, '":"') + '"}',
     function (key, value) {
+      // TODO: https://github.com/grafana/k6-studio/issues/277
+      // eslint-disable-next-line @typescript-eslint/no-unsafe-return, @typescript-eslint/no-unsafe-argument
       return key === '' ? value : decodeURIComponent(value)
     }
   )

src/utils/harToProxyData.ts

@@ -41,7 +41,9 @@ function parseRequest(request: Entry['request']): Request {
     // TODO: add actual values
     // @ts-expect-error incomplete type
     timestampStart: request.startedDateTime
-      ? // @ts-expect-error incomplete type
+      ? // TODO: https://github.com/grafana/k6-studio/issues/277
+        // @ts-expect-error incomplete type
+        // eslint-disable-next-line @typescript-eslint/no-unsafe-argument
         isoToUnixTimestamp(request.startedDateTime)
       : 0,
     timestampEnd: 0,

src/views/Generator/ExportScriptDialog/OverwriteFileWarning.tsx

@@ -9,6 +9,8 @@ export function OverwriteFileWarning() {
     setValue('overwriteFile', false)
   }
 
+  // TODO: https://github.com/grafana/k6-studio/issues/277
+  // eslint-disable-next-line @typescript-eslint/no-unsafe-argument
   const scriptName = getScriptNameWithExtension(getValues('scriptName'))
 
   return (

src/views/Generator/Generator.tsx

@@ -58,6 +58,8 @@ export function Generator() {
 
   const blocker = useBlocker(({ historyAction }) => {
     // Don't block navigation when redirecting home from invalid generator
+    // TODO(router): Action enum is not exported from react-router-dom
+    // eslint-disable-next-line @typescript-eslint/no-unsafe-enum-comparison
     return isDirty && historyAction !== 'REPLACE'
   })