ensure window state is tracked when settings dialog is open #354
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cristianoventura
requested review from
going-confetti and
Llandy3d
and removed request for
a team
Comment on lines
+585
to
+587
| // don't pass fields that are not submitted by the form | ||
| const { windowState: _, ...settings } = data | ||
| const modifiedSettings = await saveSettings(settings) |
There was a problem hiding this comment.
The main issue is the data being submitted from the form contains the previous value for windowState and the one one file gets overwritten by the one submitted by the form.
Base automatically changed from
fix/prevent-app-crash-when-settings-invalid
to
main
November 15, 2024 19:29
cristianoventura
dismissed
Llandy3d’s stale review
The base branch was changed.
Llandy3d
approved these changes
Nov 15, 2024
cristianoventura
deleted the
fix/persist-window-state-when-settings-dialog-opened
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The window state is not being persisted when the Settings dialog is open and, you move or resize the main window. This PR makes changes to the
saveSettingsfunction to ensure only fields that are being submitted from the form are being overwritten.How to Test
Checklist
npm run lint) and all checks pass.npm test) and all tests pass.Screenshots (if appropriate):
Related PR(s)/Issue(s)