feat: stream log file in Settings dialog #348
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cristianoventura
requested review from
going-confetti and
e-fisher
and removed request for
a team
| @@ -17,7 +17,7 @@ const handleCreateIssue = () => { | |||
| } | |||
|
|
|||
| const handleOpenLogs = () => { | |||
| window.studio.app.openApplicationLog() | |||
| window.studio.log.openLogFolder() | |||
There was a problem hiding this comment.
I moved handlers related to logs to its own namespace.
Comment on lines
+9
to
+10
| <Flex direction="column" pt="4" p="1" height="100%"> | ||
| {children} |
There was a problem hiding this comment.
I made some changes to the parent elements in the tab content so we use flexbox more efficiently with children items.
Llandy3d
reviewed
Nov 14, 2024
There was a problem hiding this comment.
Probably small nitpick:
Should it live under settings ?
I find it a little hard to read them there due to inability to resize and fixed size on the smaller side 🤔
I noticed that we don't have access to application logs anymore from the help menubar, was it introduced here 👀
cristianoventura
dismissed stale reviews from Llandy3d and e-fisher
via
13b214b
Llandy3d
approved these changes
Nov 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR removes the "Application log" button from the sidebar (decluttering the amount of items we currently have) and instead, shows the real-time log stream on a new tab in the Settings dialog.
How to Test
Checklist
npm run lint) and all checks pass.npm test) and all tests pass.Screenshots (if appropriate):
Related PR(s)/Issue(s)