-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add parameterization rule custom code UI #344
Conversation
de79513
to
b6894bc
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewing from the functionality standpoint, it works really well! 🚀 🚀 🚀
It's nice that we can showcase the encasing function in such a native way to the editor 🚀 🙌
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nicely done! 👏
@@ -0,0 +1,59 @@ | |||
declare module 'constrained-editor-plugin' { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
😮 Are they accepting contributions?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The repository doesn't look active lately 😞 But we have already been using this in GCk6 and had types defined there
Description
Add ability to use custom code in parameterization rules. The editor will include read-only function definition to reflect how the snippet will look in the script. In the future, this could be extended to pass arguments to parameterization function (query params, body, headers) and show inline types in the snippet editor.
How to Test
Checklist
npm run lint
) and all checks pass.npm test
) and all tests pass.Screenshots (if appropriate):
Related PR(s)/Issue(s)