feat: Add Think Time editor #20
Conversation
| <Callout.Text wrap="balance"> | ||
| It is advisable not to use this option if you have included | ||
| groups, as it may cause unexpected delays between requests, even | ||
| within a group. | ||
| </Callout.Text> |
There was a problem hiding this comment.
@Llandy3d do we still want to have this callout? The notes from June 25 say: Groups - no bother of sleep between requests, but I'm not sure how to interpret it
There was a problem hiding this comment.
yap, we still want the callout!
As for that note, sorry for that, it means how the workflow goes for the QA, if they are using groups, they don't bother about setting sleep between requests. So we shouldn't allow to select both group think time & request think time
There was a problem hiding this comment.
if they are using groups, they don't bother about setting sleep between requests.
Can't we hide the option to set sleep between request when there are groups then?
There was a problem hiding this comment.
I'm not sure hiding functionality would be a good thing, from the spec we want to encourage/warn users but leave them the flexibility of doing it anyways 🤷 (we can discuss it further, it's a good topic for the next sync)
There was a problem hiding this comment.
Yeah, let's discuss this in a sync
| @@ -0,0 +1 @@ | |||
| v18 | |||
There was a problem hiding this comment.
Should probably be v20, because electron bundles 20.9.0 with the app
Closes https://github.com/grafana/k6-cloud/issues/2506
This PR adds the ThinkTime component to the Think Time tab on the generate page