[grafana] set GF_UNIFIED_ALERTING_SCREENSHOTS_CAPTURE to true when imageRenderer is enabled #3537
+5
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kefi550
requested review from
jkroepke,
maorfr,
torstenwalter,
Xtigyro and
zanhsieh
as code owners
|
|
|
I feel this should be configurable. and please bump the chart version. |
…s enabled Signed-off-by: kefi550 <[email protected]>
Signed-off-by: kefi550 <[email protected]>
Signed-off-by: kefi550 <[email protected]>
kefi550
force-pushed
the
set_env_screenshot
branch
from
e0f61f0 to
2ae126d
Compare
|
As you wrote, it's not good that this env variable is not configurable, so I've made this env variable configurable. Thank you for reviewing. |
zanhsieh
approved these changes
Jan 22, 2025
|
I read your message, but I think is should be configurable with default true. Sometimes, there are reasons to disable "cool" feature, for example for cost reasons. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Set environment variable
GF_UNIFIED_ALERTING_SCREENSHOTS_CAPTUREto true whenimageRenderer.enabledis true.This will cause screenshots to be attached to alerts when
imageRenderer.enabledis set to true.As mentioned in #1556, currently screenshot is not attached to alerts even though
imageRenderer.enabledis set to true.It would be natural for alerts to have a screenshot attached when the imageRenderer is enabled.