Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[loki-distributed] Add minAvailable poddisruptionbudget #3510

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

stafot
Copy link
Contributor

@stafot stafot commented Jan 3, 2025

Reasoning:
In our use case we need to be able to customize minAvailable value in podDisruptionBudgets.

@stafot stafot force-pushed the loki-add-pod-disruption-budgets-customized branch from e16e389 to 1b83c11 Compare January 3, 2025 10:23
@stafot stafot changed the title Add minAvailable poddisruptionbudget in loki-distributed [loki-distributed] Add minAvailable poddisruptionbudget Jan 3, 2025
@stafot stafot requested review from torstenwalter, zanhsieh and a team as code owners January 3, 2025 10:25
@stafot stafot force-pushed the loki-add-pod-disruption-budgets-customized branch 2 times, most recently from 980cfb4 to 0486999 Compare January 3, 2025 10:43
@stafot
Copy link
Contributor Author

stafot commented Jan 3, 2025

Lint fails because helm-docs wants to change other charts, but validate wants 1 PR per chart which is reasonable. So some code was merged recently without proper documentation update that seems to leading to this problem. @unguiculus let me know what is your process to handle this and I can work on a fix.

stafot added 2 commits January 7, 2025 12:23
Signed-off-by: Stavros Foteinopoulos <[email protected]>

Update helm-docs

Signed-off-by: Stavros Foteinopoulos <[email protected]>
@stafot stafot force-pushed the loki-add-pod-disruption-budgets-customized branch from 61932aa to 784debd Compare January 7, 2025 10:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant