[lgtm-distributed] Add Grafana OnCall to the chart dependencies. #3183
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Sheikh-Abubaker <[email protected]>
Signed-off-by: Sheikh-Abubaker <[email protected]>
Signed-off-by: Sheikh-Abubaker <[email protected]>
Signed-off-by: Sheikh-Abubaker <[email protected]>
Signed-off-by: Sheikh-Abubaker <[email protected]>
Signed-off-by: Sheikh-Abubaker <[email protected]>
Signed-off-by: Sheikh-Abubaker <[email protected]>
Signed-off-by: Sheikh-Abubaker <[email protected]>
zalegrala
approved these changes
Jun 24, 2024
…into oncall-pr
zalegrala
approved these changes
Jun 24, 2024
…into oncall-pr
|
This is very nice, is there anyone else that could review this? @zalegrala |
|
Not sure who maintains this chart. I don't see owners in |
|
@zalegrala I have created it and asked to add myself to the list of maintainers in the chart, but nothing about codeowners. I guess it would be good to add 2+ people. Here is the initial PR, which was reviewed by @zanhsieh (who might have some thoughts on this). I am not part of the org, so not sure where to go from here :) |
|
@timberhill if maintainers are needed I could come up as one! |
…into oncall-pr
zanhsieh
approved these changes
Jun 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2698