[grafana] allow sc-alerts as init container #2761
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Thomas Belian <[email protected]>
bt909
requested review from
maorfr,
torstenwalter,
Xtigyro and
zanhsieh
as code owners
Signed-off-by: Thomas Belian <[email protected]>
|
I have implemented as init-container OR container. If you like to have the init-container additional to the container, I can adjust that. In my usecase, I use Grafana w/ anonymous login and the container additional to init-container makes no sense in my usecase, but maybe to have both is the more generic way. |
zanhsieh
requested changes
Nov 7, 2023
There was a problem hiding this comment.
@bt909
Can you also fix the test error?
https://github.com/grafana/helm-charts/actions/runs/6749078165/job/18348724266?pr=2761
------------------------------------------------------------------------------------------------------------------------
==> Logs of container grafana-93xwb4fza5-test
------------------------------------------------------------------------------------------------------------------------
1..1
not ok 1 Test Health
# (in test file /tests/run.sh, line 5)
# `[ "$code" == "200" ]' failed
------------------------------------------------------------------------------------------------------------------------
<== Logs of container grafana-93xwb4fza5-test
------------------------------------------------------------------------------------------------------------------------
========================================================================================================================
|
Hm, I would like to fix the test, but I am a bit confused. The test failed since I merged main.... |
Signed-off-by: Thomas Belian <[email protected]>
Signed-off-by: zanac1986 <[email protected]> Signed-off-by: Thomas Belian <[email protected]>
Signed-off-by: Nick Pillitteri <[email protected]> Signed-off-by: Thomas Belian <[email protected]>
Signed-off-by: Nick Pillitteri <[email protected]> Signed-off-by: Thomas Belian <[email protected]>
Co-authored-by: MH <[email protected]> Signed-off-by: Thomas Belian <[email protected]>
|
Oh, I am stuck in rebase hell, because of DCO. I will make an new clean PR. |
|
I will close this PR in favor of: #2771 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sidecar for datasources and notifiers are available, but not for alerts. As values.yaml in line 873 suggested, the idea is to have it as init container as well.
This PR enables the possibility to use sidecar-alerts as init-container too.
Why do we want this as init-container? To get alerts loaded, when using Grafana in anonymous mode. For datasources we have a solution, but not for alerts.
Some kind of related (but this PR don't fix it): #981