[loki-distributed] manage compactor as statefulset #2747
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rasta-rocket
force-pushed
the
loki_compactor_sts
branch
4 times, most recently
from
8f094b9 to
5c210b9
Compare
zanhsieh
approved these changes
Nov 7, 2023
|
@zalegrala |
verejoel
suggested changes
Nov 13, 2023
| - name: runtime-config | ||
| configMap: | ||
| name: {{ template "loki.fullname" . }}-runtime | ||
| {{- if not .Values.ingester.persistence.enabled }} |
There was a problem hiding this comment.
Copy paste error
Suggested change
| {{- if not .Values.ingester.persistence.enabled }} | |
| {{- if not .Values.compactor.persistence.enabled }} |
| {{- with .Values.compactor.extraVolumes }} | ||
| {{- toYaml . | nindent 8 }} | ||
| {{- end }} | ||
| volumeClaimTemplates: |
There was a problem hiding this comment.
Needs a guard here in case persistence is not enabled or the list of volume claims is empty.
rasta-rocket
force-pushed
the
loki_compactor_sts
branch
from
5177d2f to
1dc5da6
Compare
|
@verejoel I have updated the code according to your review |
|
Thanks for the PR. What's the motivation to manage the compactor as a statefulset? Is this the recommendation from Loki? |
|
Hello @zalegrala 👋 I did that for two reasons:
The recommendation from loki is to have that component to be stateful (they do not mention statefulset or deployment + pvc) Cheers ☀️ |
zalegrala
approved these changes
Nov 13, 2023
|
Ah okay, I didn't realize the compactor was stateful but I suppose this makes sense since if the client doesn't stream. |
Signed-off-by: rasta-rocket <[email protected]>
rasta-rocket
force-pushed
the
loki_compactor_sts
branch
from
5fc61b6 to
0f33126
Compare
Signed-off-by: rasta-rocket <[email protected]>
rasta-rocket
force-pushed
the
loki_compactor_sts
branch
from
7f2c109 to
6a0d637
Compare
jfcoz
added a commit
to jfcoz/grafana-helm-charts
that referenced
this pull request
Dec 23, 2023
boltdb.shipper.compactor.working-directory was missing in grafana#2747 Signed-off-by: Julien Francoz <[email protected]>
jfcoz
added a commit
to jfcoz/grafana-helm-charts
that referenced
this pull request
Dec 31, 2023
boltdb.shipper.compactor.working-directory was missing in grafana#2747 Signed-off-by: Julien Francoz <[email protected]>
jfcoz
added a commit
to jfcoz/grafana-helm-charts
that referenced
this pull request
Jan 13, 2024
boltdb.shipper.compactor.working-directory was missing in grafana#2747 Signed-off-by: Julien Francoz <[email protected]>
jfcoz
added a commit
to jfcoz/grafana-helm-charts
that referenced
this pull request
Jan 16, 2024
boltdb.shipper.compactor.working-directory was missing in grafana#2747 Signed-off-by: Julien Francoz <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey there !
Small contribution here to allow users of the chart to manage the compactor as a statefulset
values.yamlI set the compactor fieldKindasStatefulsetstarting now : this might break existing setup. I did that since Statefulset is kind of the default way to manage stateful software in k8s IMHO, but let me know what you think about it 😉If you have any question, do not hesitate to reach me 😉
Cheers ☀️