[tempo-distributed] use old root to get namespace #2740
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kaflake
requested review from
annanay25,
joe-elliott,
mapno,
mdisibio,
swartz-k,
BitProcessor,
faustodavid and
zalegrala
as code owners
zanhsieh
requested changes
Oct 29, 2023
zanhsieh
changed the title
kaflake
force-pushed
the
main
branch
4 times, most recently
from
8cf9fef to
40c322e
Compare
Signed-off-by: Nagel, Felix <[email protected]>
Co-authored-by: MH <[email protected]> Signed-off-by: Nagel, Felix <[email protected]>
Signed-off-by: Nagel, Felix <[email protected]>
|
|
|
reopen with the new version. Sorry, I'm not working so often in github :/ |
Signed-off-by: MH <[email protected]>
zanhsieh
approved these changes
Nov 24, 2023
|
What have I to do to finish this pull-request? Do I still a mistake? |
Ask other reviewers to see they have different opinions. |
|
can we please get it merged? I'm also affected and chart was unusable for me since 1.6.9. Of course i can pin to 1.6.9 and use image.tag but still. |
zalegrala
approved these changes
Dec 15, 2023
|
LGTM, the chart needs a version update. Thanks for the contribution. |
Signed-off-by: MH <[email protected]>
Signed-off-by: MH <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix bug from #2723 which produces in #2679.
Namespace-Variable was nil and cause of that its not possible to build with basicauth.